I'm glad the icons are more sane now for the hide/show pane stuff (thanks #253515: icon for show/hiding panes -- although there's a bug that the icons are currently reversed). However, it's still sort of easy to miss the fact that a pane is hidden. The editors on socialistworker.org proposed that I make hidden panes more obviously hidden by greying them out. See attached screenshot. Should I post a patch for this, or is this won't fix territory?

Comments

merlinofchaos’s picture

Category: feature » bug
Priority: Minor » Normal

Hidden panes should already be greyed out. This is a bug that they are not.

dww’s picture

Title: Usability enhancement: Use different colors on hidden panes » Usability enhancement: Use more different colors on hidden panes
Category: bug » feature
Priority: Normal » Minor
StatusFileSize
new3.08 KB

Oh, I guess there's a tiny bit of difference already. For comparison, here's what it looks like now... So, I propose to make the differences more obviously visible.

dww’s picture

StatusFileSize
new15.38 KB

Whoops, I missed. ;) Try this.

dww’s picture

Status: Active » Needs review
StatusFileSize
new1.14 KB

Here's a patch that accomplishes this so folks can try it on their own sites. Note, this happens to fix a minor bug in the .css where the grabber:hover style wasn't applied on hidden panes due to a missing leading dot, so it was using the same grabber:hover style as regular panes. Now that I tried it with the intended style, I kind of like the dark blue-ish grey, for this -- maybe we could keep that part. ;)

pancho’s picture

StatusFileSize
new21.59 KB

Here's a screenshot with all four states a pane can be in. The orange star is hardly visible for unsaved-hidden.
Also note that a different hover color is only set for saved panes. We might want to change that.

merlinofchaos’s picture

I like the colors in the screenshot. dww: Is the dark bluish-grey something different?

dww’s picture

Yes, the dark-bluish grey is this:

panel-pane.hidden-pane .grabber:hover {
   background-color: #506D7F;
}

which isn't visible without the leading .

Here's a screenshot while hovering over a hidden pane with this color in use ("orig") vs. the pure grey hover color from my patch ("dww").

merlinofchaos’s picture

What about the 'changed' pane color?

dww’s picture

@merlin: see the screenie from #5.

sdboyer’s picture

I'm all thumbs-up on this now. Committed.

sdboyer’s picture

Status: Needs review » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.