In #2695499: Improve UX when working with FPP revisions, the string "(reusable)" was added to the admin title of panes that are reusable, but since the reusable checkbox was removed from the form, there is now no indication in the modal dialog that you are editing a reusable FPP!
I propose that we add the "(reusable)" text to the modal dialog title as well.
Additionally, it might make sense to put a warning on the form similar to the one that's shown when you make an FPP reusable in the first place?
Here's some screenshots of the current situation:
I have a patch to make the admin title and title used in the modal match - I'll upload in a moment...
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | fpp-show-reusable-2717609-2.patch | 2.19 KB | dsnopek |
Comments
Comment #2
dsnopekHere's a patch that makes the modal title and the admin title the same. It also gets rid of 'No title' and falls back on the
entity_label()to preserve the fix from #2562717: Reusable FPPs without optional admin_title show nothing in 'Add content' dialog (and provide an alternate fix to #2541184: Admin title field for FPP panes (UX issue)).I think I'm going to improve this a little more, though, to get the warning on the edit form as well.
Comment #3
dsnopekNevermind about the additions I was going to make to this patch. The changes in #2541184: Admin title field for FPP panes (UX issue) accomplish what I wanted to accomplish!
Comment #5
damienmckennaCommitted. Thanks.
Comment #6
damienmckennaComment #7
damienmckenna