Closed (fixed)
Project:
Panopoly
Version:
7.x-1.x-dev
Component:
Core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 May 2016 at 19:04 UTC
Updated:
18 May 2016 at 18:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dsnopekHere's a patch that just updates the .make file. I'd like to also come up with one that sets the pane locking mode for upgraded sites, but that's coming next. I want to get the tests running first!
EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/127505399
Comment #3
dsnopekHere's an attempt to change the locking mode.
EDIT: Here's an update build: https://travis-ci.org/panopoly/panopoly/jobs/127518006
Comment #4
dsnopekThe update in #3 is working fine on Travis!
However, we're getting some failures.
The hidden_view_mode_options.feature one is failing because of this issue:
#2498623: Only show view modes with custom settings on FPP edit form
I haven't figured out the widget title link thing in livepreview.feature, only that it happens with the latest fieldable_panels_panes but not the 1.8 release. Still trying to track this down.
Comment #5
dsnopekIt's #2622808: Don't assume fieldable_panels_panes_view that's breaking "Make title a link" - if I make it always use the
fieldable_panels_panes_view()fallback, then the links start working again.Comment #6
damienmckennaI reverted #2622808: Don't assume fieldable_panels_panes_view and #2498623: Only show view modes with custom settings on FPP edit form because they were causing problems.
Comment #7
dsnopekThanks! Here's a new patch that updates to the latest fieldable_panels_panes. I'll kick off a Travis build in a moment.
EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/127556754
Comment #8
dsnopekReviewing the new UX, I'm going to hide the new 'Admin' fieldset for now. We're not showing any other vertical tabs (because we've hidden them) and so suddenly having one is odd. We can add it back in later after figuring out how it should appear!
Here's a patch to make that happen.
Comment #9
dsnopekHere's a new Travis build including the panopoly_magic patch as well:
https://travis-ci.org/panopoly/panopoly/builds/127561382
Comment #10
dsnopek@cboyden pointed out that the last patch made it impossible to set the admin title. Here's a revised version that puts the "Admin Title" back where it was in FPP 1.8.
EDIT: Here's a Travis build: https://travis-ci.org/panopoly/panopoly/builds/127598339
Comment #11
dsnopekAnd now that FPP 1.9 is out:
https://www.drupal.org/node/2718283
Here's an updated patch that uses that rather than checking out from Git.
EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/127605504
Comment #12
dsnopekFPP 1.10 was just released:
https://www.drupal.org/node/2718889
... to fix SA-CONTRIB-2016-025:
https://www.drupal.org/node/2718931
Patch updated! We'll release once this and #2483295: Title in FPP is double encoded when making a link are in.
Comment #14
dsnopekCommitted!
I'm expecting the tests on Travis to pass:
https://travis-ci.org/panopoly/panopoly/builds/127873411
But if they don't, then we'll revert and fix it. (Committing first to expedite release.)