Word on the street is that a new FPP release is coming soon! This issue is to test the latest version with Panopoly and make any changes we need to make to be compatible. The place I most expect changes to be necessary is in panopoly_magic which has a bunch of FPP-specific code.

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

Status: Active » Needs review
StatusFileSize
new845 bytes

Here's a patch that just updates the .make file. I'd like to also come up with one that sets the pane locking mode for upgraded sites, but that's coming next. I want to get the tests running first!

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/127505399

dsnopek’s picture

StatusFileSize
new1.48 KB

Here's an attempt to change the locking mode.

EDIT: Here's an update build: https://travis-ci.org/panopoly/panopoly/jobs/127518006

dsnopek’s picture

The update in #3 is working fine on Travis!

However, we're getting some failures.

The hidden_view_mode_options.feature one is failing because of this issue:

#2498623: Only show view modes with custom settings on FPP edit form

I haven't figured out the widget title link thing in livepreview.feature, only that it happens with the latest fieldable_panels_panes but not the 1.8 release. Still trying to track this down.

dsnopek’s picture

It's #2622808: Don't assume fieldable_panels_panes_view that's breaking "Make title a link" - if I make it always use the fieldable_panels_panes_view() fallback, then the links start working again.

damienmckenna’s picture

dsnopek’s picture

StatusFileSize
new1.48 KB

Thanks! Here's a new patch that updates to the latest fieldable_panels_panes. I'll kick off a Travis build in a moment.

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/127556754

dsnopek’s picture

StatusFileSize
new590 bytes

Reviewing the new UX, I'm going to hide the new 'Admin' fieldset for now. We're not showing any other vertical tabs (because we've hidden them) and so suddenly having one is odd. We can add it back in later after figuring out how it should appear!

Here's a patch to make that happen.

dsnopek’s picture

Here's a new Travis build including the panopoly_magic patch as well:

https://travis-ci.org/panopoly/panopoly/builds/127561382

dsnopek’s picture

StatusFileSize
new1.02 KB

@cboyden pointed out that the last patch made it impossible to set the admin title. Here's a revised version that puts the "Admin Title" back where it was in FPP 1.8.

EDIT: Here's a Travis build: https://travis-ci.org/panopoly/panopoly/builds/127598339

dsnopek’s picture

Title: Update to the 7.x-1.x-dev version of FPP » Update to Fieldable Panels Panes 1.9
StatusFileSize
new1.25 KB

And now that FPP 1.9 is out:

https://www.drupal.org/node/2718283

Here's an updated patch that uses that rather than checking out from Git.

EDIT: Here's the Travis build: https://travis-ci.org/panopoly/panopoly/builds/127605504

dsnopek’s picture

Title: Update to Fieldable Panels Panes 1.9 » Update to Fieldable Panels Panes 1.10 for SA-CONTRIB-2016-025
StatusFileSize
new1.25 KB

FPP 1.10 was just released:

https://www.drupal.org/node/2718889

... to fix SA-CONTRIB-2016-025:

https://www.drupal.org/node/2718931

Patch updated! We'll release once this and #2483295: Title in FPP is double encoded when making a link are in.

  • dsnopek committed 15b5009 on 7.x-1.x
    Update Panopoly Core and Magic for Issue #2717509 by dsnopek: Update to...
dsnopek’s picture

Status: Needs review » Fixed

Committed!

I'm expecting the tests on Travis to pass:

https://travis-ci.org/panopoly/panopoly/builds/127873411

But if they don't, then we'll revert and fix it. (Committing first to expedite release.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.