Right now the fieldable_panels_pane ctools plugin assumes that we want to render through fieldable_panels_panes_view. This may be a problem throughout the module but haven't had the time to check it.

Anyway, here is a patch that lookup the view callback from the entity info.

CommentFileSizeAuthor
#9 fieldable_panels_panes-n2622808-9.patch754 bytesdamienmckenna
fieldable_panels_panes-7.x-use-right-view-callback-in-ctools-plugin.patch758 bytesStoraH
fieldable_panels_panes-7.x-1.2-use-right-view-callback-in-ctools-plugin.patch950 bytesStoraH

Comments

StoraH created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

Thanks for the patches.

Please remember to change the status to "needs review" when you upload a patch, that will tell the testbot to review the changes and let others know there's something to review.

The last submitted patch, fieldable_panels_panes-7.x-1.2-use-right-view-callback-in-ctools-plugin.patch, failed testing.

  • DamienMcKenna committed f0ae5f5 on 7.x-1.x authored by StoraH 
    Issue #2622808 by StoraH: Allow the FPP entity's view callback to be...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed
Parent issue: » #2679603: Plan for Fieldable Panels Panes 7.x-1.9

Committed. Thanks!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Needs work

Am reverting this change because when Entity API is installed it breaks the optional title link.

  • DamienMcKenna committed 86905fc on 7.x-1.x 
    Issue #2718091 by DamienMcKenna: Reverted #2622808 and #2718035, added...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2679603: Plan for Fieldable Panels Panes 7.x-1.9 »
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new fieldable_panels_panes-n2622808-9.patch754 bytes

Rerolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

The last submitted patch, 9: fieldable_panels_panes-n2622808-9.patch, failed testing.