The amp module's implementation of hook_requirements() is missing the 'value', key which causes two PHP notices on the admin/reports/status page.

CommentFileSizeAuthor
#4 2717407-fix-requirements-no-value-D8.patch974 bytesdave reid
#3 2717407-fix-requirements-no-value.patch1.13 KBdave reid
#2 2717407-fix-requirements-no-value.patch1.59 KBdave reid

Comments

Dave Reid created an issue. See original summary.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2717407-fix-requirements-no-value.patch1.59 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 2717407-fix-requirements-no-value.patch1.13 KB

Ignore that previous one. :)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
StatusFileSize
new 2717407-fix-requirements-no-value-D8.patch974 bytes

Same patch for 8.x-1.x.

  • mtift committed 67620f9 on 7.x-1.x authored by Dave Reid 
    Issue #2717407 by Dave Reid: Notice: Undefined index: value in...

  • mtift committed d955ddd on 8.x-1.x authored by Dave Reid 
    Issue #2717407 by Dave Reid: Notice: Undefined index: value in...
mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
Status: Needs review » Fixed

Good catch, Dave. Committed to 7.x-1.x and 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.