Not absolutely sure this is an issue (as I stumbled onto it due to a bad site configuration - going to /saml_login on a Drupal site configured as an IdP, not as an SP), but the test for the presence of the SimpleSAML_Session::getAuthority() method (removed in SimpleSAMLphp 1.14, which I am using) seems to be wrong - on line 76 of drupalauth4ssp, the test is checking for 

if (method_exists($session, 'setAuthorityExpire')) {

rather than what I would've expected if (method_exists($session, 'getAuthority')) {. The former results in a PHP error ("PHP Fatal error: Call to undefined method SimpleSAML_Session::getAuthority()") and the latter addresses it, so I'm thinking that the wrong method was included with the test.

CommentFileSizeAuthor
drupalauth4ssp_getAuthority_method.patch612 byteslightweight

Comments

lightweight created an issue. See original summary.

greatmatter’s picture

greatmatter commented

I can confirm this.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Active » Reviewed & tested by the community

Me too. This was a typo/glitch. The patch is good.

sanchiz’s picture

sanchiz commented

  • sanchiz committed 2cb253f on 7.x-1.x authored by lightweight 
    Issue #2717039 by lightweight, greatmatter, roderik: Wrong method test...
sanchiz’s picture

sanchiz commented
sanchiz’s picture

sanchiz commented
Status: Reviewed & tested by the community » Fixed

Thank you, guys! Committed.

Available now in 7.x-1.x-dev or in 7.x-1.0-beta5 and later once released.

matason’s picture

matason commented

Patch applies cleanly and fixes the problem described, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.