Closed (fixed)
Project:
Font Awesome Iconpicker
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
1 May 2016 at 20:15 UTC
Updated:
5 Aug 2016 at 12:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hey_germanoPatch attached. This adds the formatter, as well as the option to select an icon size.
Comment #3
BigEd commentedHi great module, unfortunately its a bit of a requirement to have the output in the html so I was pleased to see that you guys have created a patch the module.
I tried to test this and I can see the field formatter but I still get no class output in the html so it's missing something.
Comment #5
d34dman commentedThanks for the contribution
Comment #6
BigEd commentedOk figured this out, it does not work at the moment as the output for fontawesome_iconpicker_field_formatter_view is only giving a blank result in the output.
However you can use the Icon field in the Icon API as this is not a text field it seems to work if you apply it and use the icon picker with it.
You have two choices we either locate the bug in the above code or make this module dependent on the Icon API.
Comment #7
d34dman commentedOh sorry i mixed up issues... this was not supposed to be committed :( Sorry.
Comment #8
d34dman commentedhi @hey_germano, this issue is assigned to you, but i would like to see this fixed asap. Are you still working on this? If not, please unassign so that other's can look into it.
Comment #9
d34dman commentedBtw, fontawesome_iconpicker already supports integration with icon_api, so is this still necessary?
Comment #10
hey_germanoApologies for the delay here. This patch should fix the bug with the formatter.
Comment #11
d34dman commentedComment #12
eric115 commented+1 for patch in #10, fixes this issue.
Comment #14
d34dman commentedThanks for the contribution and testing. Committed to 7.x-1.x-dev branch