Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
My understanding of best practices is that all tables should have a primary key to make database queries run faster.
We also need this for our database replication solution.
Comment | File | Size | Author |
---|---|---|---|
#17 | password_policy-7.x-1.x-add_a_primary_key-2715281-17.patch | 751 bytes | AohRveTPV |
| |||
#10 | password_policy_force_change_2715281-10.patch | 755 bytes | Diego_Mow |
Comments
Comment #2
rocket777 CreditAttribution: rocket777 as a volunteer commentedComment #3
rocket777 CreditAttribution: rocket777 as a volunteer commentedThis patch makes the uid column a primary key.
This patch created similar to this issue https://www.drupal.org/node/2701489
Credit to jrglasgow.
Comment #4
rocket777 CreditAttribution: rocket777 as a volunteer commentedComment #6
rocket777 CreditAttribution: rocket777 as a volunteer commentedSame patch, applies to v1.12
Comment #7
rocket777 CreditAttribution: rocket777 as a volunteer commentedComment #8
harivenuvHi roket777,
Thanks for the patch. You have little bit careful about coding stands. I have created a patch to correct the coding standard.
Comment #10
Diego_Mow CreditAttribution: Diego_Mow as a volunteer commentedChanging the hook_update number from patch password_policy_force_change_2715281-7.patch.
Comment #11
Diego_Mow CreditAttribution: Diego_Mow as a volunteer commentedComment #13
aks22 CreditAttribution: aks22 as a volunteer and at Cybage Software Pvt Ltd. commentedComment #15
aks22 CreditAttribution: aks22 as a volunteer and at Cybage Software Pvt Ltd. commentedHi, Patch-10 i have retested with 7.x-1.x password_policy_force_change_2715281-10.patch is working fine and also passed test.
So you may consider the patch-10.
Thanks.
Comment #16
aks22 CreditAttribution: aks22 as a volunteer and at Cybage Software Pvt Ltd. commentedComment #17
AohRveTPV CreditAttribution: AohRveTPV commentedChanged the update function comment slightly for consistency with other update functions. (They refer to tables using "{table_name}".)
Comment #20
AohRveTPV CreditAttribution: AohRveTPV commentedI believe this is an unrelated problem with a test method, not a problem with the patch. Will investigate the failure.
Comment #22
AohRveTPV CreditAttribution: AohRveTPV commented