Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rocket777 created an issue. See original summary.

rocket777’s picture

Issue summary: View changes
rocket777’s picture

This patch makes the uid column a primary key.
This patch created similar to this issue https://www.drupal.org/node/2701489
Credit to jrglasgow.

rocket777’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: password_policy_force_change_2715281-3.patch, failed testing.

rocket777’s picture

Same patch, applies to v1.12

rocket777’s picture

Status: Needs work » Needs review
harivenuv’s picture

Hi roket777,

Thanks for the patch. You have little bit careful about coding stands. I have created a patch to correct the coding standard.

Status: Needs review » Needs work

The last submitted patch, 8: password_policy_force_change_2715281-7.patch, failed testing.

Diego_Mow’s picture

Changing the hook_update number from patch password_policy_force_change_2715281-7.patch.

Diego_Mow’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: password_policy_force_change_2715281-10.patch, failed testing.

aks22’s picture

Issue summary: View changes

The last submitted patch, 10: password_policy_force_change_2715281-10.patch, failed testing.

aks22’s picture

Hi, Patch-10 i have retested with 7.x-1.x password_policy_force_change_2715281-10.patch is working fine and also passed test.
So you may consider the patch-10.

Thanks.

aks22’s picture

Status: Needs work » Needs review
AohRveTPV’s picture

Changed the update function comment slightly for consistency with other update functions. (They refer to tables using "{table_name}".)

Status: Needs review » Needs work

The last submitted patch, 17: password_policy-7.x-1.x-add_a_primary_key-2715281-17.patch, failed testing.

AohRveTPV’s picture

I believe this is an unrelated problem with a test method, not a problem with the patch. Will investigate the failure.

  • AohRveTPV committed b7c0375 on 7.x-1.x authored by rocket777
    Issue #2715281 by rocket777, Diego_Mow, AohRveTPV, harivenuv, aks22,...
AohRveTPV’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.