See the core issue for an example: #2702683: Add plural labels to entity types.

CommentFileSizeAuthor
#6 add_plural_labels_to_all_commerce_entity_types-2713777-6.patch12.4 KBpashupathi nath gajawada
#3 add_plural_labels_to_all_commerce_entity_types-2713777-3.patch12.39 KBpashupathi nath gajawada
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

pashupathi nath gajawada’s picture

pashupathi nath gajawada CreditAttribution: pashupathi nath gajawada as a volunteer and at Melity commented
Assigned: Unassigned » pashupathi nath gajawada

I am looking into this.

pashupathi nath gajawada’s picture

pashupathi nath gajawada CreditAttribution: pashupathi nath gajawada as a volunteer and at Melity commented
Status: Active » Needs review
FileSize
add_plural_labels_to_all_commerce_entity_types-2713777-3.patch12.39 KB

Please find the attached patch.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Needs work

Thanks!

+ *	  label_singular = @Translation("Line item"),

The label_singular line is not indented correctly in any of the annotations.

+ *     singular = "@count Checkout flow",
+ *     plural = "@count Checkout flows",

Following the core example, the singular and plural count labels need to be lowercase.

pashupathi nath gajawada’s picture

pashupathi nath gajawada CreditAttribution: pashupathi nath gajawada as a volunteer and at Melity commented

OKay, I'll update the patch.

pashupathi nath gajawada’s picture

pashupathi nath gajawada CreditAttribution: pashupathi nath gajawada as a volunteer and at Melity commented
Status: Needs work » Needs review
FileSize
add_plural_labels_to_all_commerce_entity_types-2713777-6.patch12.4 KB

Please find the attached patch.

  • bojanz committed b1057f1 on 8.x-2.x authored by GPN 
    Issue #2713777 by GPN, bojanz: Add plural labels to all Commerce entity...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.