Thanks for all the hard work in adding revision support with #1986334: Allow a particular revision of a fieldable panels pane to be placed in a panelized page.

One minor consequence of this change is that we lose the old pane-fpid-[fpid] classes, because the subtype references the revision. This can break themes which targeted styling to specific FPP entities.

I'll provide a patch shortly which adds this class when the pane is referencing the revision ID.

CommentFileSizeAuthor
#2 fieldable_panels_panes-fpid-class-2713699-2.patch681 bytesjoelstein

Comments

joelstein created an issue. See original summary.

joelstein’s picture

joelstein commented
Status: Active » Needs review
StatusFileSize
new fieldable_panels_panes-fpid-class-2713699-2.patch681 bytes
joelstein’s picture

joelstein commented
Parent issue: » #1986334: Allow a particular revision of a fieldable panels pane to be placed in a panelized page
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #1986334: Allow a particular revision of a fieldable panels pane to be placed in a panelized page » #2679603: Plan for Fieldable Panels Panes 7.x-1.9
Related issues: +#1986334: Allow a particular revision of a fieldable panels pane to be placed in a panelized page

Given this is a regression, yes, we'll add this.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks.

joelstein’s picture

joelstein commented

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.