Closed (works as designed)
Project:
Drupal core
Version:
8.1.0
Component:
Bartik theme
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Apr 2016 at 14:43 UTC
Updated:
29 Apr 2016 at 04:20 UTC
Jump to comment: Most recent
Comments
Comment #2
pashupathi nath gajawada commentedI am looking into this.
Comment #3
dcrocks commentedDo you mean, using the Bartik theme, place main menu navigation block in any region and check 'Display Title'? If you do so, the menu title block will be displayed, except if placed in the 'header' region. The latter is an anomaly being worked on elsewhere. In Bartik, 'display title' is off by default for the main menu navigation block when it is placed in its default region. But you can't assume every one will want the block title off for main menu navigation block no matter where it is placed.
This should be closed as 'works as designed'.
Comment #4
Aaron23 commented@ dcrocks
Yup using bartik theme yes, it works as per design.Only for the header region display title not used. But, I used Bootstrap theme, where the display title is not working for any region.!!
Comment #5
chi commentedWhy not just make the block title work as expected?
Comment #6
Aaron23 commentedYES works as expected...@ chi
Comment #7
Aaron23 commentedComment #8
chi commented@Aaron23, right now it does not work as designed. We should either hide the option or make it working.
Comment #9
Aaron23 commented@Chi, Yes we can make it working, as the other regions also follow the same. i mean we leave it to the user to display or hide the block title
Comment #10
dcrocks commentedNot sure which version or part of Bootstrap you are using but it does look like it is designed to never render the main menu label. But that is not the way Bartik is designed. You can achieve the same affect for any theme by providing your own version of "block--system-menu-block--main.html.twig", just as Bootstrap does.
Another issue, #2625834: Make the visibility of block titles in the header optional., is working on making all blocks work as expected in Bartik's header region. Any theme can take its own approach to this issue.
Comment #11
Aaron23 commented@dcrocks bootstrap 8.x-3.0-beta3 version component(Starterkit (LESS)).
Comment #12
chi commentedIt is not Bartik issue. The label of the block is getting overridden in the template_preprocess_block(). That is true for any other blocks with dynamic title not just for main content. I propose adding another option called "Override label".
Comment #13
dcrocks commented@chi look at #2614950: Add option for visually-hidden block titles. And this issue is about Bartik. That is where the failure occurred. Template Preprocess_Block is working as currently designed. If you want to change its behavior you need to open a new issue or tie into the issue I just pointed at.
Comment #14
emma.mariaThis is only true for the header region of Bartik. This issue is being worked on at the moment to remove that from happening - #2625834: Make the visibility of block titles in the header optional.
A user should at all times have complete control of which block titles they would like to hide or show. We shouldn't completely remove that option in Bartik for one particular instance, a user can completely configure block titles how they like.
Bartik does helps on install by setting the block title to not display for the main navigation block in it's default set region.
That is the upper limit of what the theme should provide regarding block title behaviour.
As far as the Bartik component is involved this issue bug works as designed.
However please feel free to reopen this issue within a different component.
Comment #15
dcrocks commented@chi's comments got me to look further into this and I think he has a valid comment. So I created a new issue, #2715687: make templates use 'display_label' in consistent manner, to discuss the implications of the output from template_preprocess_block