IssuePattern for username
As per current codebase user is able to create pattern without using available pattern.

Solution
we should not allow user to save the invalid pattern. need to do validation while saving the configuration

f.e.g:
if user enters
vb
Not allowed

if user enters
vb-[patterrn_name]
which is accepted

CommentFileSizeAuthor
#6 username_policy-2713369-6.patch653 bytesn.kishorekumar
#4 username_policy-2713369-4.patch653 bytesn.kishorekumar

Comments

xaiwant created an issue. See original summary.

xaiwant’s picture

xaiwant commented
Issue summary: View changes
xaiwant’s picture

xaiwant commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
n.kishorekumar’s picture

n.kishorekumar commented
Assigned: n.kishorekumar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new username_policy-2713369-4.patch653 bytes

Implemented validation for admin config form...

Please find the patch

Status: Needs review » Needs work

The last submitted patch, 4: username_policy-2713369-4.patch, failed testing.

n.kishorekumar’s picture

n.kishorekumar commented
Status: Needs work » Needs review
StatusFileSize
new username_policy-2713369-6.patch653 bytes

Adding patch again

xaiwant’s picture

xaiwant commented
Assigned: Unassigned » xaiwant
xaiwant’s picture

xaiwant commented
Assigned: xaiwant » heykarthikwithu
Status: Needs review » Reviewed & tested by the community

working fine moving to RTBC
@heykarthikwithu, just change the message before committing the code

  if ($num_of_patterns == 0) {
    form_set_error('username_policy_pattern_error', 'Please enter at least one PATTERN ELEMENTS');
  }
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Title: Allow Pattern for username » Don't allow to create pattern without using available pattern.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.