Problem/Motivation

After updating the module to get support for jw player 7 the license key is missing when was set before.

Proposed resolution

Fix it.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 interdiff-2710617-4-5.txt311 bytesjohnchque
#5 license_key_is_missing-2710617-5.patch851 bytesjohnchque
#4 interdiff-2710617-2-4.txt929 bytesjohnchque
#4 license_key_is_missing-2710617-4.patch831 bytesjohnchque
#2 license_key_is_missing-2710617-2.patch643 bytesjohnchque
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yongt9412 created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Active » Needs review
FileSize
license_key_is_missing-2710617-2.patch643 bytes

Added update function.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/jw_player.install
@@ -46,3 +46,16 @@ function jw_player_update_8001() {
+  $config = \Drupal::configFactory()->getEditable('jw_player.settings');
+  if ($config->get('license_key')) {
+    if (!$config->get('jw_player_key')) {
+      $config->set('jw_player_key', $config->get('license_key'));
+      $config->clear('license_key');
+    }

this can be a single if condition, that should be a bit easier to read.

Maybe also add a comment that the variable was renamed previously and need to make sure that the new one wasn't already set.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
license_key_is_missing-2710617-4.patch831 bytes
interdiff-2710617-2-4.txt929 bytes

That's right! Seems easier to read now! :)

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque at MD Systems GmbH commented
FileSize
license_key_is_missing-2710617-5.patch851 bytes
interdiff-2710617-4-5.txt311 bytes

Save missing right? :)

  • Berdir committed 705ac7a on 8.x-1.x authored by yongt9412 
    Issue #2710617 by yongt9412: License key is missing after update
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Moved the save into the if, we don't need to save if we don't change anything. Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.