Remove the sms_send() function and divert users to the $provider->queue() facility. In rare circumstances code may use $provider->send().

Remaining usages in SMS Framework:

  • 1x sms.module
  • 1x sms.rules.inc (old code)
  • 1x sms_actions.module (due to be updated for D8)
  • 3x tests (SmsSendTest)

None of these usages block removal of the function. None do any of these usages (other than tests) use the return value, so compatibility with $provider->queue() is not an issue.

Comments

dpi created an issue. See original summary.

dpi’s picture

Status: Active » Needs review
StatusFileSize
new6.38 KB

Status: Needs review » Needs work

The last submitted patch, 2: remove-sms-send-2709921.patch, failed testing.

The last submitted patch, 2: remove-sms-send-2709921.patch, failed testing.

The last submitted patch, 2: remove-sms-send-2709921.patch, failed testing.

dpi’s picture

Status: Needs work » Needs review
StatusFileSize
new7.81 KB

added skip queue / missing direction

  • dpi committed 2d55127 on 8.x-1.x
    Issue #2709921 by dpi: Remove sms_send()
    
dpi’s picture

Status: Needs review » Fixed

Committed without changes to #6

The last submitted patch, 2: remove-sms-send-2709921.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 6: remove-sms-send-2709921-6.patch, failed testing.

dpi’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.