Remove the sms_send() function and divert users to the $provider->queue() facility. In rare circumstances code may use $provider->send().
Remaining usages in SMS Framework:
- 1x sms.module
- 1x sms.rules.inc (old code)
- 1x sms_actions.module (due to be updated for D8)
- 3x tests (SmsSendTest)
None of these usages block removal of the function. None do any of these usages (other than tests) use the return value, so compatibility with $provider->queue() is not an issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | remove-sms-send-2709921-6.patch | 7.81 KB | dpi |
| #2 | remove-sms-send-2709921.patch | 6.38 KB | dpi |
Comments
Comment #2
dpihttps://github.com/dpi/smsframework/pull/30
Comment #6
dpiadded skip queue / missing direction
Comment #8
dpiCommitted without changes to #6
Comment #11
dpi