I've updated the query used for 'function hosting_get_servers()' to use the new db_select() function in Drupal7.

This also allowed me to add the "node_access" tag very easily, which was something that we needed.

Patch and branch attached.

CommentFileSizeAuthor
#3 2709565-server-db-select.patch1.03 KBjon pugh

Comments

Jon Pugh created an issue. See original summary.

  • Jon Pugh committed 2aad038 on 2709565-server-db-select
    Issue #2709565: Convert function hosting_get_servers() to use db_select...
jon pugh’s picture

StatusFileSize
new1.03 KB

  • helmo committed 4186ecb on 7.x-3.x authored by Jon Pugh
    Issue #2709565 by Jon Pugh: Convert function hosting_get_servers() to...
helmo’s picture

Status: Needs review » Fixed

Thanks.

ergonlogic’s picture

Just a follow-up note: let's try to reduce our use of magic numbers. Presumably, 's.available' here is just a boolean, so perhaps we could use TRUE instead. Alternatively, define('HOSTING_SERVER_AVAILABLE', 1);, or whatever we'd want to name the constant.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.