Add a helper to phone number provider to get entities with a specified phone number.

This would reduce a small amount of complexity for #2707723: Update register via SMS feature to use phone number provider.

CommentFileSizeAuthor
#3 phone-number-getentities-2709463.patch6.39 KBdpi

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Related issues: +#2679467: Remove sms_user_get_uid()
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
StatusFileSize
new phone-number-getentities-2709463.patch6.39 KB

https://github.com/dpi/smsframework/pull/27

Added getPhoneVerificationByPhoneNumber method and associated tests.

  • dpi committed 788f635 on 8.x-1.x 
    Issue #2709463 by dpi: Added getEntitiesByPhonenumber function to phone...
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs review » Fixed

Patch included the refactoring mentioned in OP for #2707723: Update register via SMS feature to use phone number provider.

Status: Fixed » Needs work

The last submitted patch, 3: phone-number-getentities-2709463.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.