Regarding javascript I want to turn on strict. In the past it has saved my bacon on multiple occasions.

I ran the javascript through the lint checker and fixed things up.

the lint checker has a gate to prevent console.log() commands from appearing in the final code.

but hey this is a developer friendly module so I am going to leave that in.

CommentFileSizeAuthor
jslint-0.patch2.64 KBmartin107

Comments

martin107 created an issue. See original summary.

  • joachim committed ccc69c9 on 8.x-3.x authored by martin107
    Issue #2709447 by martin107: Fixed JS lint checker warnings.
    

  • joachim committed cb90620 on 7.x-2.x authored by martin107
    Issue #2709447 by martin107: Fixed JS lint checker warnings.
    
joachim’s picture

Status: Needs review » Fixed

Thanks!

Committed to both active branches.

(I don't think the JS is currently in use by the D8 version of the module, but I've committed it anyway as it's functionality that I'll be adding back at some point, so it might as well receive this improvement in the meantime.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.