When setting up a course outline. There is no way to add a webform node that is not of the "webform" content type.

So say you have a custom content type and mark it as a webform. It won't allow you to associate that content type with the course.

CommentFileSizeAuthor
#2 2708805-2-webform-node-type-support.diff467 bytesdobe

Comments

dobe created an issue. See original summary.

dobe’s picture

dobe commented
StatusFileSize
new 2708805-2-webform-node-type-support.diff467 bytes

So far this is what fixed it. I will continue to make sure this solves all issues.

dobe’s picture

dobe commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2708805-2-webform-node-type-support.diff, failed testing.

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented

It failed with:

23:00:06 Fatal error: Call to undefined function webform_node_types() in /var/www/html/sites/all/modules/course/modules/course_webform/course_webform.classes.inc on line 60
23:00:07 FATAL CourseWorkflowTestCase: test runner returned a non-zero error code (255).

I'm not quite sure why though...

The last submitted patch, 2: 2708805-2-webform-node-type-support.diff, failed testing.

dobe’s picture

dobe commented

Yeah I couldn't figure it out either. Considering webform is a requirement in the test. And that function resides in the webform.module file...

Seems like something hoaky with the test.

webservant316’s picture

webservant316 commented

I just ran into this problem also. I changed the machine name of 'webform' to 'form' for readability for for my end user since I put the [content-machine-name] token in the URL. Any as you know currently the course module only handles one form content type and it must be named 'webform'. In my use case I just reverted back and changed 'form' to 'webform' and all works again.

I see the patch above handles adding multiple form content types. If it isn't working I would be suspicious that a hard coded 'webform' found it way into the code somewhere else.

The last submitted patch, 2: 2708805-2-webform-node-type-support.diff, failed testing.

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Fixed

Doesn't fail any more. Must have been an issue with DrupalCI.

Fixed!

  • djdevin committed a84b28c on 7.x-1.x authored by dobe 
    Issue #2708805 by dobe: Webform Node Course Outline
webservant316’s picture

webservant316 commented

super, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.