After updating to Features 2.9 when doing a drush fl no output is shown. Any tips on how to get this working? Or is it a bug?

Comments

Argus created an issue. See original summary.

Cyclodex’s picture

Title: Drush fl returns no output since updating to 2.9 » Drush fl returns no output since updating to 2.8

Which version of Drush are you using ?

I had the same issue with drush 5.9, and I think it should work with Drush 6.x or higher.

Also the output change was introduced in Features 2.8 so it seems.

gngn’s picture

Same here. I just updated from 7.x-2.7 to 7.x-2.9 (left out 2.8)
Now drush features-list returns nothing (uisng drush 5.9).
With 2.7 I got the expected list of my features.

A short look revealed that

  • 2.9 (and I think 2.8 too) drush_features_list() returns $rows (an array filled with feature information) and leaves the actual outputting to the standard drush output system
  • while 2.7 used drush_print_table() to print out $rows itself.

I don't know if anybody else is interested but the following quick patch tests the drush version and falls back to the 2.7 behaviour if drush version is lower than 5.9 (apply at the end of drush_features_list())

--- features.drush.inc	(revision 837)
+++ features.drush.inc	(working copy)
@@ -245,6 +245,9 @@
       );
     }
   }
+  if (version_compare(DRUSH_VERSION, '6.0', '<')) {
+    drush_print_table($rows, TRUE);
+  }
   return $rows;
 }
gngn’s picture

Status: Active » Needs review
mpotter’s picture

Status: Needs review » Needs work

Can you post this as an actual patch file so things like the testbot will see it. Thanks.

mpotter’s picture

Status: Needs work » Needs review
StatusFileSize
new325 bytes

OK, going to post the patch since this is important to fix asap for Drush 5 folks (which still sadly includes drupal.org)

  • mpotter committed 1f1b3e4 on 7.x-2.x
    Issue #2707427 by mpotter: Drush fl returns no output since updating to...
mpotter’s picture

Status: Needs review » Fixed

Committed to 1f1b3e4.

gngn’s picture

Sorry, I didn't have the time to create an actual patch.
Nevertheless ‎I would have been happy to be mentioned in a features commit...

Cyclodex’s picture

Wow that was quick, thanks folks! :)

Argus’s picture

Confirming fl works fine again.

mpotter’s picture

gngn: sorry about you getting dropped from the commit comment. I was just using the default git commit line that the dreditor plugin supplies to get a quick fix out. But maybe this will encourage a patch in the future? :)

(git diff >features-issuenum-commentnum.patch easy!)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.