The version of iCalcreator required by this module is not PHP 7 compatible, because it uses class constructors with the same name as the class.

Not sure how to resolve this, since we can't upgrade to a newer version of the library. Or can we?

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

joelstein created an issue. See original summary.

joelstein’s picture

Status: Active » Needs review
FileSize
2.79 KB

At the very least, here's a patch you can apply to the iCalcreator library for PHP 7 support.

coredumperror’s picture

We can't upgrade to a newer version of the library without needing to also make significant changes to the Feeds import code. If anyone wants to put in the work to figure out what changes need to be made, mostly having to do with the way date_ical's code accesses member attributes that have been renamed/protected in the new version, I'd be happy to accept the patch. But my team isn't going to be using PHP 7, so my boss won't give me any cycles to work on this myself.

joelstein’s picture

Understood. Perhaps in the meantime you could add something to the README file pointing to this patch?

coredumperror’s picture

Good idea.

joelstein’s picture

Here's an updated patch with one constructor I missed.

axel.rutz’s picture

Status: Needs review » Postponed (maintainer needs more info)

Current ICalCreator 2.24 has this fixed.
https://github.com/iCalcreator/iCalcreator/tree/v2.24

Anyone tested if this is interoperable with us?

EDIT: Ups, #3 says: NO.