Issue fork auto_entitylabel-2707027

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

piyuesh23 created an issue. See original summary.

peacog’s picture

peacog commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
dman’s picture

dman commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Category: Task » Feature request

Would be great, and should be pretty easy to do I believe.

After introducing this module late in a build, I'd really live to be able to apply it retroactively.

Note: it looks like simply re-saving the entity will trigger a re-label. That wasn't explicit, but makes sense I guess.

That may do for now for me, but still, exposing a simple entity action to VOB or Rules would have been nice structure.

mortona2k’s picture

mortona2k commented

I think this is a great idea, maybe add the option to the Automatic Label settings form where you can bulk update it for that entity. Adding a config page is another option, where you could manage all entity labels.

mortona2k’s picture

mortona2k commented

As a quick workaround, you can use the content admin page to bulk unpublish and republish content, which will update the title.

antonyanimator’s picture

antonyanimator commented

Any possible update on this? Unpublish Publish works is good as a workaround but not great

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Version: 8.x-2.x-dev » 8.x-3.x-dev

DeaOm made their first commit to this issue’s fork.

DeaOm opened merge request !1

deaom’s picture

deaom commented
Status: Active » Needs review

I added the option to re-save the labels on the auto entity label form for each entity, which then if checked, does the re-saving of entities via batch process in chunks which can also be set (default value is currently set to 50). It is done for comment, media, node and taxonomy term. Not sure if that rounds all of the entities that this module supports. But still needs a review so marking it as that.

Anonymous’s picture

Anonymous (not verified) commented

Hello,
I have tested changes made in this issue fork and I can confirm that the options that were added are working as they should be and entity labels gets re-saved successfully.
Regarding the code it would be nice if you could provide some comments on the methods in *Batch classes.
The code is pretty much self explanatory, but when I run phpcs --standard=Drupal,Drupalpractice on changes made in this issues fork I get the following notices for each of classes in Batch directory. 

FILE: /web/modules/contrib/auto_entitylabel-2707027/src/Batch/ResaveNodeBatch.php
---------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------
  8 | ERROR   | [x] Doc comment short description must end with a full stop
 11 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
 14 | ERROR   | [x] Missing function doc comment
 23 | ERROR   | [x] Missing function doc comment
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs review » Needs work

Updating status based on my GitLab review and #11.

Personally though, I'm not a fan of adding comments if they don't add value, even though the Drupal coding standards would disagree with me. I'd rather go with the Clean Code philosophy (where the code should be clear enough that comments aren't required), but that's just my opinion. Let's see what the maintainers think. (Oh wait! Turns out I'm one of them.)

deaom’s picture

deaom commented
Status: Needs work » Needs review

I changed my approach in dealing with the loading of the different core entities, so there is no more of the repeating of the class. Also added missing comments. Needs another review, so marking it as that.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

I retested the changes made by #13 and now the duplicates classes are merged into a single class and the comments were also added.
Marking this as RTBC.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Version: 8.x-3.x-dev » 8.x-3.0-beta4

Added to beta4. If you'd like to see a stable release, please help with issues in #3153250: Roadmap for a stable 8.x-3.x release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.