Problem/Motivation

E_ERROR: Call to a member function getFileUri() on null

Proposed resolution

Fix function and test it

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 2706717-3.patch2.44 KBalexpott
#3 2706717-3.test-only.patch1.67 KBalexpott
#2 2706717-2.patch792 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
2706717-2.patch792 bytes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2706717-3.test-only.patch1.67 KB
2706717-3.patch2.44 KB

Here's a test.

The last submitted patch, 3: 2706717-3.test-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2706717-3.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs work » Needs review

The two test fails in the non test-only patch are due to #2595673: Test Drupal\Tests\feeds\Unit\Feeds\Target\DateTimeTest is broken and #2707033: Fix CsvParserTest.

twistor’s picture

twistor CreditAttribution: twistor commented
Issue tags: -Needs tests

So this is because we're breaking all private file downlods?

  • twistor committed 78e8aeb on 8.x-3.x authored by alexpott 
    Issue #2706717 by alexpott: PHP notice coming from feeds_file_download
twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented
Status: Needs review » Fixed

The last submitted patch, 2: 2706717-2.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.