Follow-up to #2701969: core/composer.txt is out of date

Problem/Motivation

core/composer.txt lists libraries we officially depend on. Now that depencies are built via composer rather than committed to the git repo, this can be inferred. Removal of this file means it would no longer have to be maintained.

Proposed resolution

Remove the core/composer.txt file.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 core_composer_txt_may-2706447-5.patch1.09 KBeli-t

Comments

Eli-T created an issue. See original summary.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Is this a documentation issue, asking whether we need it around for documentation purposes, or a base system issue, asking whether we need it for some technical reason?

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented

We don't need it for any technical reason so as I see it this is just documentation. It was suggested in #2701969-7: core/composer.txt is out of date that the file be removed.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

OK. Given that we have a companion composer.json file right there, I think this file can be deleted. It has no information about what composer is, and simply duplicates the information in composer.json (which to a developer who cares about composer and such, is perfectly readable IMO).

So I support making a patch that removes the file.

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
StatusFileSize
new core_composer_txt_may-2706447-5.patch1.09 KB

Here is a patch that does that

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Active » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Issue tags: +rc eligible

This is rc eligible as it is a docs only change (https://www.drupal.org/core/d8-allowed-changes#rc)

  • webchick committed 7560a81 on 8.2.x 
    Issue #2706447 by Eli-T, jhodgdon: core/composer.txt may no longer be...

  • webchick committed 061b59e on 8.1.x 
    Issue #2706447 by Eli-T, jhodgdon: core/composer.txt may no longer be...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

This totally makes sense. :) Reviewed with @effulgentsia. Only removing a horribly out of date text file which can be derived from the .json which is always accurate. +1!

Committed and pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.