Problem/Motivation

The top of core/composer.txt states

The libraries listed here are the only ones we officially depend on. Anything
else is either provided only for development purposes or an implicit dependency
that may be removed in the future, if it is properly decoupled from the packages
depending on it.

However it seems to be missing some libraries that should be captured by that definition.

Proposed resolution

Add the missing dependencies to composer.txt

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 core_composer_txt_is-2701969-2.patch502 byteseli-t

Comments

Eli-T created an issue. See original summary.

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Issue summary: View changes
StatusFileSize
new core_composer_txt_is-2701969-2.patch502 bytes

Added

  • paragonie/random_compat as it implements random_bytes(), called from Drupal\Component\Utility\Crypt::randomBytes()
  • symfony/polyfill-iconv as it implements iconv(), called from Drupal\Component\Utility\Unicode::convertToUtf8()
eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Status: Active » Needs review
eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Version: 8.2.x-dev » 8.1.x-dev

No reason to wait until 8.2.x to fix this, even if it can't go in to 8.1.0-rc1.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Nice find!

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Issue tags: +rc eligible

This is rc eligible as it is a docs only change (https://www.drupal.org/core/d8-allowed-changes#rc)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed cb557b6 and pushed to 8.1.x and 8.2.x. Thanks!

It might be worth creating a follow issue to remove this file. It was more relevant when we were including all of our dependencies in git but now we should just use composer.json and its require-dev feature to manage this.

  • alexpott committed c163a98 on 8.2.x 
    Issue #2701969 by Eli-T: core/composer.txt is out of date

  • alexpott committed cb557b6 on 8.1.x 
    Issue #2701969 by Eli-T: core/composer.txt is out of date

(cherry...
eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented

Raised #2706447: core/composer.txt may no longer be required as suggested in #2701969-7: core/composer.txt is out of date

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.