Problem:

Keeping purge.logger_channels.yml and purge.plugins.yml in config/install prevents install profiles from installing with site specific config.

These files are essentially blank in purge, however, they prevent sites from installing with their own config file (without jumping through hoops using a hook_install.

Proposed solution:

Remove them from the codebase.

CommentFileSizeAuthor
#3 remove-default-purge-config-2705497-3.patch493 bytestraviscarden
#2 remove_default_purge_config_2705497-2.yml493 bytesarknoll

Comments

arknoll created an issue. See original summary.

arknoll’s picture

arknoll commented
StatusFileSize
new remove_default_purge_config_2705497-2.yml493 bytes
traviscarden’s picture

traviscarden commented
Status: Active » Needs review
StatusFileSize
new remove-default-purge-config-2705497-3.patch493 bytes

Oops. Let's give that patch the correct filename extension and send it off to the testbot.

nielsvm’s picture

nielsvm commented

Anyone actually tested this patch? Because I can assure you that it breaks a whole lot of things ;).

However, I'll look into this to see if we can ship with the defaults in code.

slasher13’s picture

slasher13
Primary language German
commented

I can install with an install profile with custom config.

nielsvm’s picture

nielsvm commented
Title: Keeping purge.logger_channels.yml and purge.plugins.yml in config/install prevents install profiles from installing with site specific config » make purge work without defaults in config/install/*.yml (install profiles support)

  • nielsvm committed ff00e94 on 8.x-3.x 
    Issue #2705497 by TravisCarden, arknoll, nielsvm, slasher13: make purge...
nielsvm’s picture

nielsvm commented

I'm happy to announce this commit: http://cgit.drupalcode.org/purge/commit/?id=ff00e94

This now means that purge now ships without default CMI yml files and should therefore take away the reported inconveniences. However, please note that this ain't a guarantee that I won't reintroduce defaults in the near future. In fact, if #2795141 turns out to be a big refactor, chances exist that defaults need to come back somehow - for instance for the queue plugin.

This change will land in 8.x-3.0-beta5.

Niels

nielsvm’s picture

nielsvm commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.