I've accidentially found a very tiny bug. I don't know, if this class is ever used anywhere, since the product overview page is acutally a View.

However, as long the ProductListBuilder is existing, it should be correct. In the buildHeader() function, there's a classic copy&paste error. $header['status'] is defined twice, instead of 'status'.

CommentFileSizeAuthor
fix_ProductListBuilder_header_typo.patch531 bytesagoradesign

Comments

agoradesign created an issue. See original summary.

  • bojanz committed 6f844bb on 8.x-2.x authored by agoradesign 
    Issue #2704801 by agoradesign: Typo in ProductListBuilder::buildHeader()
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Yeah, the list builders for content entities are mostly unused (the views handlers use the operations part).

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

lukasss’s picture

lukasss commented

I also saw this point ))).
Patch applied, but file ProductListBuilder and line annotations are left.