Invalid 3rd argument to range() causing errors adding panes [#270392]

In revision 1.1.2.50, merlinofchaos added the following to panels_add_content():

foreach (range($columns, 2, -1) as $column) {

However, check out the PHP docs for range():

http://us2.php.net/manual/en/function.range.php

2 problems here:

1) the 3rd arg is supposed to be positive.
2) the 3rd arg is only PHP5 -- at this point, panels works fine in PHP4 based on my testing -- it'd be a shame to introduce a PHP4 dependency just for this.

The good news is that the docs state: "If low > high, the sequence will be from high to low.", so the -1 is useless. If you rip it out, everything seems to work as intended, even on PHP4.

See attached patch.

Comment	File	Size	Author
	panels_range_3rd_arg.patch	833 bytes	dww

Comments

Comment #1

dww

we/he/they

commented 13 June 2008 at 22:42

Note, the CVS logs show:

revision 1.1.2.50
date: 2008-06-02 16:39:07 +0000;  author: merlinofchaos;  state: Exp;  lines: +3 8 -11;  commitid: 6954484422284567;
Change the add pane dialog to an easier to read, more space conservative layout.

So there's no issue for these changes to post this to...