Problem/Motivation

The tests on the module are failing.

Proposed resolution

Fix them.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 interdiff-2703821-2-4.txt542 bytesjohnchque
#4 fix_tests-2703821-4.patch2.41 KBjohnchque
#2 fix_tests-2703821-2.patch2.29 KBjohnchque

Comments

yongt9412 created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Active » Needs review
StatusFileSize
new fix_tests-2703821-2.patch2.29 KB

Fixed the tests and updated the comments.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Looks fine, means of course that we lose test coverage for e.g. advertising. Maybe add a @todo to improve that and add a follow-up issue for it?

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
StatusFileSize
new fix_tests-2703821-4.patch2.41 KB
new interdiff-2703821-2-4.txt542 bytes

Added todo message. Created related issue: #2703933: Add javascript tests. :D

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Related issues: +#2703933: Add javascript tests

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.