Using the media library with CKeditor to embed an oEmbed video fails due to the CKEditor stripping out iframes.

Steps to reproduce:

  • Enable media_oembed and dependencies
  • Configure CKeditor using WYSIWYG module for the 'Full HTML' text format, media button integration, and the media filter
  • Create a new article and click the media button
  • Create a new web file pointing to a Vimeo video
  • Embed this into the WYSIWYG field
  • Save the node

Result:
This process will result in a missing video, as the CKEditor strips out iframes. This is not overridable.

Expected result:
Video appears in the page.

CommentFileSizeAuthor
#7 support_ckeditor-2702477-7.patch692 bytesdevin carlson
#3 interdiff-support_ckeditor-2702477-3.txt602 bytesgollyg
#3 support_ckeditor-2702477-3.patch797 bytesgollyg
#2 support_ckeditor-2702477-2.patch736 bytesgollyg

Comments

gollyg created an issue. See original summary.

gollyg’s picture

gollyg commented
StatusFileSize
new support_ckeditor-2702477-2.patch736 bytes

Adding a check in the formatter to see if we are in the WYSIWYG picker. If we are, use the thumbnail representation.

Image style needs work. Ideally it would load up the oembed Thumbnail settings for the given view mode.

gollyg’s picture

gollyg commented
StatusFileSize
new support_ckeditor-2702477-3.patch797 bytes
new interdiff-support_ckeditor-2702477-3.txt602 bytes

Added a lookup for the default thumbnail image style.

gollyg’s picture

gollyg commented
Status: Active » Needs review
davisben’s picture

davisben
Primary language English
Location NH, USA
commented
Status: Needs review » Reviewed & tested by the community

The patch in #3 works perfect for me.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

+1 on the patch in #3

devin carlson’s picture

devin carlson commented
Title: Support CKEditor integration » Add workaround for Media WYSIWYG's image-only WYSIWYG support
Category: Feature request » Task
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new support_ckeditor-2702477-7.patch692 bytes

The check for $file->override['wysiwyg'] is sufficient as File Entity's file display can be configured to either call the oEmbed thumbnail formatter after the oEmbed formatter fails and will default to "Large filetype icon" if no acceptable formatter is found.

I'd also recommend embedding files using Entity Embed or another solution which doesn't require this workaround.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Tested #7 and committed to Media: oEmbed 7.x-2.x.

  • Devin Carlson committed bc4bdfd on 7.x-2.x authored by gollyg 
    Issue #2702477 by gollyg, Devin Carlson: Add workaround for Media...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.