Active / Inactive toggle for rules

OK, I had not thought of that. Thanks for the hint. Yes I can see that I can export a single reaction rule, then delete the rule to allow a code switch to the non-rules branch, then re-import when I want to work on that branch of the code again. But I have created 15 separate reaction rules as part of testing my conversion from 7.x to 8.x so it is a great overhead in time to export all 15, delete them, then import all 15 later. And do that all again, if I need to switch branches to make a fix to the real code.

Are there any plans to implement the active/non-active toggle? If you would like it, but have not got round to looking at it, I could give it a try.

That looks brilliant. I've not got any account on github.com - what is the best way for me to test your changes? Can I extract them as a patch file? Or should I download your entire branch. I am currently on rule 8.x-3.0-alpha1+10-dev on my localhost, which is now a month out of date.

By the way, you confuse me when you say the screenshots are from D7 - this issue is only to fix D8, I think D7 version works just fine (?)

Thanks for the explanation. Thank you also for giving the url for the patch - that is very good, and I can see that you have made another commit and it all gets wrapped up into the one patch.

I have tested it manually and found no problems so far. Changing the status via the checkbox and via the drop-down list both work correctly with no errors. Enabled rules are triggered and disabled rules are not triggered.

I tried running the tests which you changed, by selecting just \Drupal\Tests\rules\Functional\ConfigureAndExecuteTest and \Drupal\Tests\rules\Functional\UiPageTest on the testing UI page. However, this produced the error message "No test results to display". Not sure what is going on there - maybe these tests cannot be run in isolation?

Hope that helps - and thank you for providing this functionality so quickly after I raised the issue.

I was about to test the minor change from #10 but unfortunately the combined patch no longer applies (was ok at alpha1+12, but not now at alpha1+17). The problem is GenericEventSubscriber.php which has changed right at the point where this patch added the 'status=1' criteria:

@@ -119,8 +119,10 @@ public function onRulesEvent(Event $event, $event_name) {
     // variables added by one rule are not interfering with the variables of
     // another rule.
     foreach ($triggered_events as $triggered_event) {
-      // @todo Only load active reaction rules here.
-      $configs = $storage->loadByProperties(['events.*.event_name' => $triggered_event]);
+      $configs = $storage->loadByProperties([
+        'events.*.event_name' => $triggered_event,
+        'status' => 1,
+      ]);

Here is the code comparison:

I will revert to using alpha1+12 for now, as this toggle it vital for me, and it is not easy to see exactly how I should make the manual change for the failed hunk.

Following the reworking of GenericEventSubscriber onRulesEvent() as described above, I have finally worked out a way to filter for only enabled rules. I am sure this is not the best way, but it's a start. There is now no change to GenericEventSubscriber.php and the filtering is done in RulesExpression/Rule.php function executeWithState() instead. Apart from these two files, the other five in the patch have not changed.

I know that the entity.manager should be injected, but I am doing this just for 'proof of concept' or to see if others have better ways to do it. Also I realise that development has to take place on GitHub first. I am just submitting the patch to see how this goes and if I'm on the right lines.

Well, I have no idea what happened there, but one nice thing ... the two modified tests to check the enable/disable functionality both passed OK.

Just to see if those test failures are anything to do with my patch, here is a dummy patch which changes nothing but a comment.

I was trying to make @yanniboi's code work back in 2016. Thank you @TR for all your work on this, and so many other Rules issues.