Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
Framework
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Apr 2016 at 13:02 UTC
Updated:
16 May 2016 at 07:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
drunken monkeySimple patch attached, I think there is no real discussion needed about the labels, and it seems to work.
One question is whether we now want to also use entities' plural labels somewhere in the module? Could justify a look. (Or we can just keep our eyes open to see if we spot something.)
Comment #3
rosinegrean commentedI saw some comments from @bojanz on related tasks about the last commas, here is an example: https://www.drupal.org/node/2702745#comment-11052643
but @amateescu who was running the sprint where these changes were made, did not really agree they were mandatory.
However, for https://www.drupal.org/node/2703323 i've tested with the commas and had no issues.
As far as i know, there is no standard on this. Or am i wrong ?
Comment #5
drunken monkeyAs written in the other issue, I actually thought that including those trailing commas gave you a parse error (like in JSON). But I now see we already have those in some places, so if this ever was the case, it apparently changed quite some time ago.
All the better, I prefer it with trailing commas, too. Thanks for pointing this out!
Added the commas and committed.
Thanks again!
Comment #6
vaibhavjainHey Drunken Monkey, Prics,
I am using 8.0.x and the above said patch may work only for 8.1.x as PluralTranslation is not available in 8.0.x
I can go ahead and undo changes in this patch, just wanted to know if this will have any impact on the working of this module.
Also, if that is the case, please have a release for 8.0.x or mark the module for 8.1.x only.
Thanks.
Comment #7
drunken monkeyDrupal 8.0.x has reached its end of life as of ten days ago, if I understand correctly, so I don't think we have to provide any compatibility with that – especially since our own module isn't stable yet.
I might have misunderstood the new release cycle, but unless I'm mistaken, you should probably get used to updating pretty soon after a new minor version of Core is released. And after a Core version's last security release window, I wouldn't count on any new versions of contrib modules to be compatible with that anymore.
But to answer your question, you can just remove the patch, it doesn't have any real consequences.
Comment #8
vaibhavjainHey,
I wasn't aware of this release cycle.
I have removed the code, and things looks to be good until now.
Thanks for the reply.