Problem/Motivation

It's difficult to extend the responsive-image.html.twig template in small ways, because every implementation of the template duplicates everything, rather than extending. But it is particularly difficult because the majority of the logic still happens in a preprocess function.

Proposed resolution

Remove template_preprocess_responsive_image(), move its logic into the Twig template.

But keep BC for the Stable & Classy themes, so duplicate that preprocess function to stable.theme.

Remaining tasks

  1. First do these 3 soft-blockers:
    1. #2423743: streamline responsive_image_build_source_attributes()
    2. #2421317: Do #attributes/$variables['attributes'] to go the <picture> or the fallback <img>?
    3. #2701255: responsive_image_preprocess_responsive_image() and responsive-image.html.twig never render width and height variables despite claiming otherwise
  2. Then start pushing this forward, and consider adding a image_style_url($image_url, $image_style) Twig function (see #3)

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 remove_template_preprocess_responsive_image-2701667-5.patch10.85 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2423743: streamline responsive_image_build_source_attributes(), +#2421317: Do #attributes/$variables['attributes'] to go the <picture> or the fallback <img>?, +#2701255: responsive_image_preprocess_responsive_image() and responsive-image.html.twig never render width and height variables despite claiming otherwise

Strongly related:

  1. #2423743: streamline responsive_image_build_source_attributes()
  2. #2421317: Do #attributes/$variables['attributes'] to go the <picture> or the fallback <img>?
  3. #2701255: responsive_image_preprocess_responsive_image() and responsive-image.html.twig never render width and height variables despite claiming otherwise

All 3 of those issues simplify/remove WTFs in the preprocess function, and would therefore help make this issue happen.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Note that for this particular issue (unlike #2694179: Remove template_preprocess_image() and #2699635: Remove template_preprocess_form_element_label() for example), it probably makes sense to define additional Twig functions.

For example: besides the file_url() and url() Twig functions, also having image_style_url($image_url, $image_style) would be very valuable. It may even be a necessity to make this issue happen. But it would also be valuable to front-end developers in other templates.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes

Updated IS per #2 and #3.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new remove_template_preprocess_responsive_image-2701667-5.patch10.85 KB

Here's what we can do for now.

Status: Needs review » Needs work

The last submitted patch, 5: remove_template_preprocess_responsive_image-2701667-5.patch, failed testing.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

catch’s picture

catch
he/him
Primary language English
commented
Parent issue: » #3260399: [meta] Theme/render system cleanup

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.