Problem/Motivation

It's difficult to extend the form-element-label.html.twig template in small ways, because every implementation of the template duplicates everything, rather than extending. But it is particularly difficult because the majority of the logic still happens in a preprocess function.

Proposed resolution

Remove template_preprocess_form_element_label(), move its logic into the Twig template.

But keep BC for the Stable & Classy themes, so duplicate that preprocess function to stable.theme.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#25 Screenshot 2022-06-10 at 12.51.24 PM.png288.95 KBMadhu Kumar M E
#24 interdiff_20_24.txt632 bytesrassoni
#24 2699635-24.patch8.58 KBrassoni
#20 interdiff-2699635-18_20.txt1.37 KBgauravvvv
#20 2699635-20.patch8.58 KBgauravvvv
#18 2699635-18.patch8.63 KBranjith_kumar_k_u
#17 2699635-17.patch8.63 KBranjith_kumar_k_u
#2 remove_template_preprocess_form_element_label-2699635-2.patch8.72 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new remove_template_preprocess_form_element_label-2699635-2.patch8.72 KB
dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/system/templates/form-element-label.html.twig
@@ -8,12 +8,37 @@
+{% if element['#title'] is not empty %}
+{% set title = element['#title'] %}
+{% endif %}
+{% set title_display = element['#title_display'] %}
+{% if element['#required'] is not empty %}
+  {% set required = element['#required'] %}

Could we add all those variables to hook_theme() for now, so we don't up in using # in templates? I doubt we want to do that on the longrun.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Yeah I agree it's ugly/painful/questionable.

I'd especially like front-end folks' thoughts on that though.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

catch’s picture

catch
he/him
Primary language English
commented
Parent issue: » #3260399: [meta] Theme/render system cleanup
ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 2699635-17.patch8.63 KB

Re-rolled #2 for 9.4

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 2699635-18.patch8.63 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work
Issue tags: +@deprecated

still needs to fix CS and there's no more spaceless tag and not clear why "screenreader is unknown

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 2699635-20.patch8.58 KB
new interdiff-2699635-18_20.txt1.37 KB

Re-rolled patch #18, Attached interdiff for same.
Screenreader is now changed to screenreaders.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 20: 2699635-20.patch, failed testing. View results

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

rassoni’s picture

rassoni commented
Status: Needs work » Needs review
StatusFileSize
new 2699635-24.patch8.58 KB
new interdiff_20_24.txt632 bytes

Reroll the patch.

Madhu Kumar M E’s picture

Madhu Kumar M E commented
StatusFileSize
new Screenshot 2022-06-10 at 12.51.24 PM.png288.95 KB

I applied patch #24 , It's not applied successfully added screenshot for reference.

Status: Needs review » Needs work

The last submitted patch, 24: 2699635-24.patch, failed testing. View results

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.