Hi there!

Not sure why, but it seems like no one noticed yet: If you have any other language than english you aren't able to show "All" results on the results page.

Thats because the label is used for the GET-parameter, instead of the value. The label works fine, as long as it's not translated :D

I'm on it and will post a patch in a few minutes.

CommentFileSizeAuthor
#3 webform-show_all_items-2701029-2.patch1.56 KBserkanb
#2 webform-show_all_items-2701029-1.patch1.56 KBserkanb

Comments

SerkanB created an issue. See original summary.

serkanb’s picture

serkanb commented
StatusFileSize
new webform-show_all_items-2701029-1.patch1.56 KB

Here comes the patch.

serkanb’s picture

serkanb commented
StatusFileSize
new webform-show_all_items-2701029-2.patch1.56 KB

Well... last second changes without proper testing are still a bad thing.

Now using is_numeric() instead of is_int().

pankajsachdeva’s picture

pankajsachdeva commented
Issue summary: View changes
serkanb’s picture

serkanb commented
Issue summary: View changes
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks for the patch in #3. It would be great if it had tests. Can you explain what the second hunk in the patch is for?

Status: Needs review » Needs work

The last submitted patch, 3: webform-show_all_items-2701029-2.patch, failed testing. View results

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Closed (outdated)

Drupal 7 is no longer supported. If this applies to a supported version, please re-open.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.