We've introduced 3 coding standards regression in the 8.1.x cycle. We should fix them in the rc phase. The coding standards that core complies with a defined in core/phpcs.xml.dist
We should fix these two:


FILE: ...odules/big_pipe/tests/modules/big_pipe_test/big_pipe_test.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...vdisk/dev/sites/drupal8alt.dev/core/modules/system/system.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 335 | ERROR | [x] Doc comment star missing
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

The third coding standard fail is in BigPipeTestController.php but we don't need to fix it because we're removing all the @file docblocks in #2665992: @file is not required for classes, interfaces and traits

CommentFileSizeAuthor
#5 fix_coding_standards-2700475-5.patch1.24 KBcilefen
#5 interdiff.txt1.06 KBcilefen
#3 fix_coding_standards-2700475-3.patch1.26 KBcilefen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Issue summary: View changes
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Active » Needs review
FileSize
fix_coding_standards-2700475-3.patch1.26 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Needs work 
+++ b/core/modules/system/system.module
@@ -332,7 +332,7 @@ function system_theme_suggestions_field(array $variables) {
-+ *                         available if the entity type uses bundle entities.
+ *                         available if the entity type uses bundle entities.

I don't think the whitespace is correct here. See https://www.drupal.org/coding-standards/docs#lists - i think we should just follow the wrap around rule.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.06 KB
fix_coding_standards-2700475-5.patch1.24 KB

... and the module file comment may as well match the info file description.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Looks great thanks!

  • catch committed 980b119 on 8.2.x 
    Issue #2700475 by cilefen: Fix coding standards regressions

  • catch committed 1085f53 on 8.1.x 
    Issue #2700475 by cilefen: Fix coding standards regressions

(cherry...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and 8.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.