Closed (fixed)
Project:
Currently Logged-in Users
Version:
8.x-1.0
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Apr 2016 at 12:59 UTC
Updated:
20 Apr 2016 at 10:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
n.kishorekumar commentedcode for the filter based on uid in the current user listing page,
Please find the patch
Comment #3
n.kishorekumar commentedComment #4
xaiwant commented@N.kishorekumar i can view use id filter has been added for currently logged in user.
seems ok .
moved to RTBC
Comment #5
krknth commentedInstead of uid, pls use username
Comment #6
krknth commentedComment #7
n.kishorekumar commented@krknth
Replaced user id search with user name filter
Comment #8
heykarthikwithupatch not applying.
Comment #9
n.kishorekumar commentedPlease find the updated patch
Comment #10
xaiwant commentedComment #11
xaiwant commented@N.kishorekumar, Username filter is working as per expected
Few minor changes needs to be updated.
1. Can we have button in right side of search field. Or else we should have space below.
2. Intendation problem exist here
3. reading
op, needs to be read as a string.+ $submit_value = $form_state->getValues()[op];4. should be append with out changing existing query.
5. line of code can be optimized in this case
$search_unamerefer: https://www.drupal.org/coding-standards
Comment #12
xaiwant commentedComment #13
xaiwant commentedComment #14
n.kishorekumar commentedCode was updated with the coding standards...
Please find the patch
Comment #16
heykarthikwithuCommitted with few changes..