Closed (fixed)
Project:
Flag
Version:
8.x-4.x-dev
Component:
Flag core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Apr 2016 at 09:58 UTC
Updated:
18 Apr 2016 at 18:14 UTC
Jump to comment: Most recent
I am splitting an issue off from this comment.
https://www.drupal.org/node/2542860#comment-11034683
It looks like FlaggingConfirmForm is not actually used
It is closely related to FlagConfirmForm and UnConfirmForm. Maybe the original intent was to do both jobs in a generic way
I would rather maintain two separate but closely related class each with a clear intent rather than have a single class with so many if statement in it doing the same job.
| Comment | File | Size | Author |
|---|---|---|---|
| FlaggingConfirmForm-0.patch | 2.8 KB | martin107 |
Comments
Comment #3
socketwench commentedI think the class was once the only class for the confirm form, but several refactorings later we just don't use it.