Need to add tests for all submodules, so that bugs like #2699173: [Syntax Error] ... metatag\\Tag\\OgUpdatedTime can be avoided.

CommentFileSizeAuthor
#13 metatag-n2699297-13.patch10.45 KBdamienmckenna
#9 metatag-n2699297-9.patch11.61 KBdamienmckenna
#2 metatag-n2699297-2.patch4.34 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2699297-2.patch4.34 KB

This enables the metatag_open_graph and metatag_twitter_cards modules, and then passes 'twitter_cards_type' to all config forms as it's a required option.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: metatag-n2699297-2.patch, failed testing.

The last submitted patch, 2: metatag-n2699297-2.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The error is:

Uncaught PHP Exception Drupal\Core\Config\Schema\SchemaIncompleteException: "Schema errors for metatag.metatag_defaults.global with the following errors: metatag.metatag_defaults.global:tags.twitter_cards_type missing schema" at /var/www/html/core/lib/Drupal/Core/Config/Testing/ConfigSchemaChecker.php line 98

So, something is off with the .. schema?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Update tests to enable all submodules » Add tests for submodules
Issue summary: View changes
Parent issue: #2699057: Plan for Metatag 8.x-1.0-beta7 release » #2699381: Plan for Metatag 8.x-1.0-beta8 release

The last submitted patch, 2: metatag-n2699297-2.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2699297-9.patch11.61 KB

Rerolled, and fixed some issues in the twitter_cards schema.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: metatag-n2699297-9.patch, failed testing.

The last submitted patch, 9: metatag-n2699297-9.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n2699297-13.patch10.45 KB

Hopefully fixed the schema this time.

  • DamienMcKenna committed 8e2d9de on 8.x-1.x 
    Issue #2699297 by DamienMcKenna: Added tests to ensure submodules can be...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Yay!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.