This emits PHP notice User error: Invalid placeholder (!name) in string: when you check watchdog messages.
!placeholder was removed a long time ago.

CommentFileSizeAuthor
#2 2699267-2.patch1.18 KBchi

Comments

Chi created an issue. See original summary.

chi’s picture

chi commented
Status: Active » Needs review
StatusFileSize
new 2699267-2.patch1.18 KB

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

kalpaitch’s picture

kalpaitch commented
Status: Needs review » Reviewed & tested by the community

I am still getting this error in 8.1.0.

Tested and reviewed patch, this should go in.

  • catch committed aa6235f on 8.2.x 
    Issue #2699267 by Chi: Wrong placeholder format in...
catch’s picture

catch
he/him
Primary language English
commented

The lack of test fails means we have no coverage for this condition, opened #2734033: Missing test coverage in file_unmanaged_save_data for that.

This particular bug though doesn't need test coverage in itself - it's just a straight omission from a previous patch.

Committed/pushed to 8.2.x. Need to think about the impact of the string change on 8.1.x vs. the notice. So leaving RTBC there

xjm’s picture

xjm
she/her
Primary language English
commented

Discussed with @catch. I think it makes sense to backport this because it is very much an admin-facing message, and sites' logs are being bloated with both broken messages and notices from this.

Maybe we should hold it until just after 8.1.2 is tagged to give translators more time to update the translation?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c2062bf and pushed to 8.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.