[Syntax Error] ... metatag\\Tag\\OgUpdatedTime [#2699173]

site CRASH after upgrade of metatag 8.x-1.0-beta-6
The problem is metatag_open_graph.

[Sat Apr 02 23:31:30.852502 2016] [:error] [pid 28958] [client 178.51.201.143:59153] Uncaught PHP Exception Doctrine\\Common\\Annotations\\AnnotationException: "[Syntax Error] Expected PlainValue, got ''' at position 439 in class Drupal\\metatag_open_graph\\Plugin\\metatag\\Tag\\OgUpdatedTime." at /home/newsplusd8/pu
blic_html/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationException.php line 42, referer: http://newsplusd8.arduinna-web.ovh/admin/config/search/metatag
[Sat Apr 02 23:32:26.327558 2016] [:error] [pid 3192] [client 178.51.201.143:59166] Uncaught PHP Exception Doctrine\\Common\\Annotations\\AnnotationException: "[Syntax Error] Expected PlainValue, got ''' at position 439 in class Drupal\\metatag_open_graph\\Plugin\\metatag\\Tag\\OgUpdatedTime." at /home/newsplusd8/pub
lic_html/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationException.php line 42, referer: http://newsplusd8.arduinna-web.ovh/admin/config/search/metatag
[Sat Apr 02 23:32:34.310659 2016] [:error] [pid 3192] [client 178.51.201.143:59173] Uncaught PHP Exception Doctrine\\Common\\Annotations\\AnnotationException: "[Syntax Error] Expected PlainValue, got ''' at position 439 in class Drupal\\metatag_open_graph\\Plugin\\metatag\\Tag\\OgUpdatedTime." at /home/newsplusd8/pub
lic_html/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationException.php line 42, referer: http://newsplusd8.arduinna-web.ovh/admin/config/search/metatag
[Sat Apr 02 23:32:49.147012 2016] [:error] [pid 6885] [client 178.51.201.143:59180] Uncaught PHP Exception Doctrine\\Common\\Annotations\\AnnotationException: "[Syntax Error] Expected PlainValue, got ''' at position 439 in class Drupal\\metatag_open_graph\\Plugin\\metatag\\Tag\\OgUpdatedTime." at /home/newsplusd8/pub
lic_html/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationException.php line 42, referer: http://newsplusd8.arduinna-web.ovh/admin/structure
[Sat Apr 02 23:32:51.236435 2016] [:error] [pid 5780] [client 178.51.201.143:59182] Uncaught PHP Exception Doctrine\\Common\\Annotations\\AnnotationException: "[Syntax Error] Expected PlainValue, got ''' at position 439 in class Drupal\\metatag_open_graph\\Plugin\\metatag\\Tag\\OgUpdatedTime." at /home/newsplusd8/pub
lic_html/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationException.php line 42, referer: http://newsplusd8.arduinna-web.ovh/admin/structure

by-pass is to uninstall metatag_open_graph :

drush pm-uninstall metatag_open_graph

Same problem on 2 D8 sites...

Comment	File	Size	Author
#13	metatag-n2699173-13.patch	4.43 KB	damienmckenna
#4	metatag-n2699173-4.patch	1023 bytes	damienmckenna
#3	metatag-n2699173-3.patch	470 bytes	damienmckenna

Comments

Comment #1

2 April 2016 at 22:49

Didier Misson created an issue. See original summary.

Comment #2

didier misson commented 2 April 2016 at 22:50

Issue summary:

View changes

Status	File	Size
new	metatag-n2699173-3.patch	470 bytes

Comment #4

damienmckenna

TN, USA

commented 3 April 2016 at 00:38

Status	File	Size
new	metatag-n2699173-4.patch	1023 bytes

1 file was hidden/shown/deleted

Status	File	Size
hidden	metatag-n2699173-3.patch	470 bytes

This updates one of the tests to also enable the Open Graph and Twitter Cards submodules, just to make sure simply enabling them doesn't break the site.

Comment #5

didier misson commented 3 April 2016 at 00:39

Thanks Damien.
I go to test the 2 patches now.
Didier

Comment #6

gillesbailleux

French

La Roche-en-Ardenne

commented 3 April 2016 at 00:40

We make a backup and test patch #4

Comment #7

3 April 2016 at 00:47

Status:

Needs review

» Needs work

The last submitted patch, 4: metatag-n2699173-4.patch, failed testing.

Comment #8

3 April 2016 at 00:52

The last submitted patch, 4: metatag-n2699173-4.patch, failed testing.

Comment #9

3 April 2016 at 01:08

The last submitted patch, 4: metatag-n2699173-4.patch, failed testing.

Comment #10

didier misson commented 3 April 2016 at 01:08

I just test patch # 4
with MySQL and PHP7.

.../public_html/modules/metatag# patch -p1 <  /root/download/metatag-n2699173-4.patch 
patching file metatag_open_graph/src/Plugin/metatag/Tag/OgUpdatedTime.php
patching file src/Tests/MetatagAdminTest.php

Test seem ok !
Site is up, running, with Metatag Open Graph enable.

Thanks.
Didier

Comment #11

damienmckenna

TN, USA

commented 3 April 2016 at 01:46

The following error is triggered when saving admin/config/search/metatag/global:
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for metatag.metatag_defaults.global with the following errors: metatag.metatag_defaults.global:tags.twitter_cards_type missing schema in Drupal\Core\Config\Testing\ConfigSchemaChecker->onConfigSave() (line 98 of core/lib/Drupal/Core/Config/Testing/ConfigSchemaChecker.php).

Comment #12

damienmckenna

TN, USA

commented 3 April 2016 at 01:56

Submitting the form works ok, but the tests result in an error.

Comment #13

damienmckenna

TN, USA

commented 3 April 2016 at 11:33

Status:

Needs work

» Needs review

Status	File	Size
new	metatag-n2699173-13.patch	4.43 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	metatag-n2699173-4.patch	1023 bytes

The twitter_cards_type field is a required field.

Comment #14

3 April 2016 at 11:36

Status:

Needs review

» Needs work

The last submitted patch, 13: metatag-n2699173-13.patch, failed testing.

Comment #15

3 April 2016 at 11:36

The last submitted patch, 13: metatag-n2699173-13.patch, failed testing.

Comment #16

3 April 2016 at 11:49

DamienMcKenna committed 40e54fc on 8.x-1.x

Issue #2699173 by DamienMcKenna: Fix OgUpdatedTime annotations.

Comment #17

damienmckenna

TN, USA

commented 3 April 2016 at 11:52

Status:	Needs work	» Fixed
Parent issue:		» #2699057: Plan for Metatag 8.x-1.0-beta7 release

I'm moving the test changes into #2699297: Add tests for submodules and have committed the patch from #3.

Comment #18

damienmckenna

TN, USA

commented 3 April 2016 at 18:21

Priority:

Major

» Critical

This was critical.

Comment #19

didier misson commented 3 April 2016 at 23:17

Thanks Damien.

I will try to test this new release this evening.
Didier

Comment #20

didier misson commented 11 April 2016 at 23:47

Hi Damien

We have test and upgrade several sites, and all seem ok now, with Beta 7 !

Thanks for your very fast action to correct this bug.
;-)
Didier

Comment #21

damienmckenna

TN, USA

commented 12 April 2016 at 00:45

@Didier Misson: I'm very happy to hear it :)

Comment #22

26 April 2016 at 00:44

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

[Syntax Error] ... metatag\\Tag\\OgUpdatedTime

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Parent issue

News items

Our community

Documentation

Drupal code base

Governance of community