Unless I am missing something, it looks like code was refactored with this latest release that eliminates ALL watchdog logging when msgs aren't using queue.

smtp.module::smtp_send_queue_runner():125

    // Let the people know what is going on.
    if ($logging == SMTP_LOGGING_ALL) {
      watchdog('smtp', 'Sending mail to: @to', array('@to' => $message['to']));
    }

But that section of code is missing before the $mailer->send() in smtp.mail.inc::mailWithoutQueue():533.

CommentFileSizeAuthor
#4 smtp-n2698029-4.patch548 byteswundo

Comments

mbnsorg created an issue. See original summary.

damienmckenna’s picture

Version: 7.x-1.3 » 7.x-1.x-dev
Status: Active » Postponed (maintainer needs more info)

Can you please show where that might have been added?

mbnsorg’s picture

Looks like the issue was introduced in this commit, related to smtp.mail.inc
http://cgit.drupalcode.org/smtp/commit/?id=19e7c1028ccd7cf6f12416a6e8e68...

Looks like the commit was to support a queueing scenario, but the effect was the removal of logging for the ALL config setting when sending mail through function mailWithoutQueue(array $message).

wundo’s picture

Priority: Normal » Major
Status: Postponed (maintainer needs more info) » Needs review
Issue tags: -logging
StatusFileSize
new548 bytes

  • wundo committed a0a85e4 on 7.x-2.x
    Issue #2698029 by wundo: Fixes watchdog not being logged for messages...

  • wundo committed d178d75 on 7.x-1.x
    Issue #2698029 by wundo: Fixes watchdog not being logged for messages...
wundo’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.