| Comment | File | Size | Author |
|---|---|---|---|
| #3 | youtube-deprecated-methods-2697657-3a.patch | 3.24 KB | guschilds |
| #3 | youtube-deprecated-methods-2697657-3.patch | 5.34 KB | guschilds |
| #2 | youtube.patch | 5.29 KB | Swetha Yarla |
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | youtube-deprecated-methods-2697657-3a.patch | 3.24 KB | guschilds |
| #3 | youtube-deprecated-methods-2697657-3.patch | 5.34 KB | guschilds |
| #2 | youtube.patch | 5.29 KB | Swetha Yarla |
Comments
Comment #2
Swetha Yarla commentedI have removed the deprecated methods \Drupal::config, \Drupal::l, urlInfo and changed to $this->config, Link::fromTextAndUrl , toUrl
Please find the attached patch.
Comment #3
guschilds commentedHi Swetha,
Thanks for the patch!
Unfortunately it did not apply because of recent changes made to the 8.x-1.x branch. I re-rolled it and attached it as
youtube-deprecated-methods-2697657-3.patch. I ran into a couple of issues (with Drupal 8.0.5). First:
Are you sure
\Drupal::configis deprecated? The use of$this->config()instead was causing the issues above. I could not find any mention of\Drupal::configbeing deprecated on its documentation, recent release notes, or Drupal's "Deprecated" page.After removing that change I ran into:
I added
use Drupal\Core\Link;to the top of the page to fix that.Along with those two changes, I also scanned the rested of the Deprecated page and found something else in this module that has since been deprecated: SafeMarkup. I've removed it in favor of its suggested alternatives.
I've rolled these 3 changes into another patch I've attached, youtube-deprecated-methods-2697657-3a.patch. Please test that patch and let me know if it works for you.
Comment #5
guschilds commentedSwetha,
Because I wanted to make a release involving other recent commits, I went ahead and committed everything except the
$this->configstuff I mentioned having an issue with. I'm going to go ahead and close this issue, but if you are able to find information about\Drupal::configbeing deprecated and are able to create a working patch, please re-open this and attach it. Thanks so much for your help!