Accidentally entering the wrong path on a website served from NGINX will not allow for automatic searching or parsing of keys derived from the URL path alias.

As some major hosting companies use NGINX servers, this could be an issue for anyone using Search 404 on those systems.

The problem arises from the following server request on line 26 of search404.module: 

  if (empty($keys)) {
    $keys = \Drupal::request()->server->get('REDIRECT_URL');
  }

get('REDIRECT_URL') will only work on Apache web servers. More information here.

I attempted a patch myself, but have had no success with the new Drupal 8 path API. Perhaps someone smarter than me can take a look at this issue?

So far I have tried to make use of the following with no luck as they render the internal path rather than the user's input:

\Drupal::service('path.current')->getPath();
\Drupal::request()->getRequestUri();
CommentFileSizeAuthor
#14 keys_from_path_do_not_work-2697197-11.patch1.04 KBmagi.yv
#13 keys_from_path_do_not_work-2697197-11.patch825 bytesmagi.yv
#9 keys_from_path_do_not_work-2697197-9.patch765 bytesmagi.yv
#6 keys_from_path_do_not_work-2697197-5.patch696 bytesmagi.yv

Comments

rich_dawson created an issue. See original summary.

rich_dawson’s picture

rich_dawson commented
Issue summary: View changes
heikki’s picture

heikki commented

This is not a correct solution, but I used this to pick keys from the url:

    $path = \Drupal::service('path.current')->getPath();
    $paths = explode('/', $path);
    $keys = end($paths);

This obviously only picks the last segment of the path, but it's enough for my use-case.

You could try this if you are using OR query in search api (or whatever search module you are using).

    $path = \Drupal::service('path.current')->getPath();
    $keys = str_replace('/', ' ', $path);
anish_zyxware’s picture

anish_zyxware commented

@heikki
Can you make it as a patch? I don't have an nginx instance right now to test it. So I was postponing it indefinitely.

magi.yv’s picture

magi.yv commented
Assigned: Unassigned » magi.yv
magi.yv’s picture

magi.yv commented
Assigned: magi.yv » Unassigned
Status: Needs work » Needs review
StatusFileSize
new keys_from_path_do_not_work-2697197-5.patch696 bytes

@heikki
could you please review this patch.

AsadKamil’s picture

AsadKamil commented
Status: Needs review » Reviewed & tested by the community

Patch applied successfully,
thanks.

magi.yv’s picture

magi.yv commented
Version: 8.x-1.0-alpha2 » 8.x-1.x-dev
Assigned: Unassigned » magi.yv
Status: Reviewed & tested by the community » Needs work
magi.yv’s picture

magi.yv commented
StatusFileSize
new keys_from_path_do_not_work-2697197-9.patch765 bytes

Created a patch to fix the issue when using 'OR query' in search.

mslabba_zyxware’s picture

mslabba_zyxware commented
Status: Needs work » Fixed

Successfully merged the patch

mslabba_zyxware’s picture

mslabba_zyxware commented
Status: Fixed » Needs work

This patch will fix this particular issue, but has effect on other areas.
After applying this patch 'disable search' functionality does not works as expected

magi.yv’s picture

magi.yv commented
Assigned: magi.yv » Unassigned
Status: Needs work » Needs review
StatusFileSize
new keys_from_path_do_not_work-2697197-11.patch825 bytes

Fixed issue on 'OR' query and disable search feature. Please review the patch.

magi.yv’s picture

magi.yv commented
StatusFileSize
new keys_from_path_do_not_work-2697197-11.patch1.04 KB

mslabba_zyxware’s picture

mslabba_zyxware commented
Status: Needs review » Fixed

Successfully merged the patch

anish.a’s picture

anish.a commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.