Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If user accessed media library first, and has seen the checkmark icon on thumbnails, then he will expect to see same visual indicator that images in upload box are selected. Beside checkmark icon animation and suggested box for selecting files, this can be improved with default drupal interaction, if we use string "Remove file" with "X" icon included it should be better visual indicator for user to understand that uploaded files can be removed from list.
Elements from theme Seven:
First suggestion:
Second, improved suggestion:
Comment | File | Size | Author |
---|---|---|---|
#23 | checkmark_indicator_for-2696915-23.patch | 5.49 KB | dagmar |
#21 | Screenshot from 2016-05-13 16:13:07.png | 55.51 KB | johnchque |
#21 | checkmark_indicator_for-2696915-21.patch | 5.54 KB | johnchque |
#16 | 6bd2cea4d1b1d26319c0e3af88d59ddc.jpg | 24.05 KB | Dragan Eror |
#10 | screenshot.png | 177.09 KB | Nenad |
Comments
Comment #2
Nenad CreditAttribution: Nenad commentedComment #3
Nenad CreditAttribution: Nenad commentedComment #4
Nenad CreditAttribution: Nenad commentedComment #5
Nenad CreditAttribution: Nenad commentedComment #6
Nenad CreditAttribution: Nenad commentedComment #7
miro_dietikerBy looking at the styleguide, i see that we should only display a cross (X) and only show "remove" on hover.
I think that removes a large amount of clutter from the UI.
The cross could be displayed above an edge of the image, on top of a negative circle.
Comment #8
Nenad CreditAttribution: Nenad commentedHere is another design suggestion (image 3), this time cross is displayed above the image. Full size image https://invis.io/4X6S7OVV7#/145088089_Issue_4_2
Comment #9
miro_dietikerWith the label below the image, it looks like "Remove" was the image label. This is misleading.
IMHO a Remove hint should show up next to the cross, similar to the design guide above.
And the space below the image is unused.
Comment #10
Nenad CreditAttribution: Nenad commentedI tried to follow seven theme style guide and made another design suggestion. Remove icon is now inside the border and it is positioned on the right side above the image. Also states, colors and styles are same like in theme seven style guide. Please check and review.
p.s. There was the idea to put cross inside the image area, but then we would need background behind the icon and text so it can be readable, since cross is dark (by styleguide) we would need white background overlay and on the other tab in the same popup window we already have image overlay for file title but in black color. All in all it would be unnecessary complication to make everything consistent and I decided not to go with that for now.
Comment #11
Nenad CreditAttribution: Nenad commentedComment #12
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedI agree this looks a bit strange as it doesn't use standard styling of elements.
The reason is the fact that we're using default theme of the DropzoneJS uploader (see http://www.dropzonejs.com/ for demo and other info). Since it is very easy to theme it it would make sense to create a custom Drupal theme for it. Having a design for it is a great first step which will make this much easier to do.
The only thing that looks a bit strange on #10 is the size of the drop area. Would it make sense to make it smaller and maybe move it to a side and make it use only a part of the available width?
Or maybe we could make it of the same size as the thumbnails and make it look like it is first/last element in the list?
Comment #13
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedI think that this belongs to the DropzoneJS integration module.
Comment #14
Primsi CreditAttribution: Primsi at Examiner.com for Examiner.com commentedAs mentioned by slashrsm, that's Dropzone default themem, but DropzoneJs can be easily themed, and that would be the best way to approach that.
Regarding the suggested designs, my vote goes to "Second, improved suggestion", because it's a very minimal design, that can be used in every admin theme.
Comment #15
miro_dietikerI tried to request a minimalistic version with my comments #7, #9 and the new proposals are IMHO always one step forward and two back.
I don't like the recent double boxing. It makes everything cluttered.
I like the cross above the image edge and the removal of the label below.
The cross just needs to expand. when the "remove" is displayed.
Alternatively, please remove the double border / padding and let the image fill the whole tile.
Also if you are really upfor the background color, you should use the light blue and not the brownish. Brownish is only proposed while upload is in progress.
Comment #16
Dragan Eror CreditAttribution: Dragan Eror at Examiner.com commentedIt's great to see someone works on these improvements!
First of all I'd like to thank Nenad for his great contribution, there is no so many designers willing to help with Drupal UX improvements.
I see great examples above and with small changes we can get right solution.
I have noticed in examples above, and in discussion, no one mentioned file types other than images!!! In DZ is possible also to upload any kind of files, and not all of them have thumbnail preview! So, some icons are needed, at least for most used file types, and one icon to cover other types.
I might also say I do not like default DZ UI because it is not very useful. Everything is crammed together in one thumbnail size of an image. There must be better solution.
Files below each other is better solution for several reasons: Desktop gets better info, it's better for small screens, in case of non-image files icons don't need to be giant.
Here is an image with solution that I like more, with few improvements can fit into Seven theme:
I do not like removing icon as "X" mark, for me it means "Stop current progress", or "Close this", but definitely not "Delete" or "Remove". I suggest using an icon of trash can (see example: https://d13yacurqjgara.cloudfront.net/users/45876/screenshots/2186659/20...).
I didn't check, but I expect trash can icon is not included in Drupal core, but that shouldn't stop future inclusion, whether in core or in contrib.
For "Delete" label it is not enough to just put there on mouse over, we must care about accessibility on all devices. For desktop screens maybe we don't even need label, simple tooltip would be just fine. But for touch screens mouse over doesn't mean anything.
Comment #17
Dragan Eror CreditAttribution: Dragan Eror at Examiner.com commentedRemoving accidental changes of issue summary.
Comment #18
miro_dietikerThank you for participating and going one step further Dragan.
This issue was limited in scope and thus achievable. The primary goal was to remove the clutter "Remove file" that looks more like a label than an action...
IMHO that's easy to fix and it boosts UX.
Your proposal is a major refactoring in appearance and thus needs a new issue.
If someone jumps right into it, we could postpone the small fixing issues. But as long as this kind of refactoring is more a long term goal, the smaller fixes still make sense.
Comment #19
johnchque@Dragan Eror thanks for the visual suggestion, indeed it looks nice but we should also consider core standards. As @miro_dietiker said, it is a major refactoring and the scope for this issue is to remove the label to make it work with core standards. I think it would be a great idea if a new issue is open with your proposal tagged as a META issue, that would help people to write suggestions and start coding based on them.
Comment #20
johnchqueComment #21
johnchqueAdded icons, IMHO looks better now.
Comment #22
Primsi CreditAttribution: Primsi for Examiner.com commentedLooks ok, just needs a re-roll.
Comment #23
dagmarRerolled.
Comment #24
slashrsm CreditAttribution: slashrsm at MD Systems GmbH commentedBesides few missing newlines at the end of files (which can be fixed on commit) look OK. Thank you!
Comment #26
Primsi CreditAttribution: Primsi for Examiner.com commentedCommitted, thanks to everyone :)
Comment #27
Primsi CreditAttribution: Primsi for Examiner.com commentedImprovement proposed in #16 can be continued at #2718847: Make UI more drupal core-like