During testing of #2689337: Add Prism support as a submodule for codefilter, it was discovered that code with tags in comments doesn't parse correctly.
An example:
/**
* Callback to escape content of <?php , , <% %>, and [% %] elements.
*/
function _codefilter_prism_escape_php_tag_callback($matches) {
return codefilter_prism_escape($matches[2], 'php');
}
?>
Next comment will have a patch which demonstrates the failing functionality (tests should fail).
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | interdiff.txt | 6.35 KB | cameron tod |
| #10 | without-prism.png | 214.84 KB | cameron tod |
| #10 | with-prism.png | 185.43 KB | cameron tod |
| #10 | 269451-php-code-tags-in-comments-10.patch | 10.15 KB | cameron tod |
| #2 | 2694541-php-code-tags-in-comments.patch | 5.64 KB | cameron tod |
Comments
Comment #2
cameron tod commentedComment #4
drummThis patch handles
<em>This has an em HTML tag surrounding it</em>, which it seems is over-decoded.Comment #5
drummThe 0 byte patch was my fault. This should be better.
Comment #8
drummI see #4 is a completely separate issue, #2694791: <code><em>HTML in code</em></code> is not properly escaped with Prism.
Comment #9
cameron tod commentedThis was actually solved almost ten years ago, here: #38047: "?>" string prematurely stops syntax highlighting
But I'm not sure the approach in that issue is the one we want to take today.
Comment #10
cameron tod commentedI got most of the way there on fixing this. There are still some minor test fails, but they seem to be only on trailing carriage returns rather than anything fundamental.
I am uploading this patch for review but will try to sort the failures tonight if I can.
One thing to note is that Prism seems to do something weird with php tags too - even though the raw text output looked ok my end once prism processed it php tags would be missing in the display.
I have attached screenshots of how things look with this patch, with and without Prism.
I'm expecting to see a bunch of fails on this test.