Configurable target menu for dynamic link items [#269398]

Firstly, the June 10th build really works well - I have not issues with it at all!

I would like to make the following request: Have the dynamic menu items ( user album, albums, etc. ) be created in a configurable menu/submenu ( exactly how the core Drupal 6.2 works - selection box of existing menus ).

I utilize a navigation bar with drop-down menu items for rendering my primary menu. I do not use the navigation block at all.

Thank-you for your excellent gallery2 integration module!

Comment	File	Size	Author
#8	gallery_menu_useralbum.patch	1.54 KB	profix898

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

profix898 CreditAttribution: profix898 commented 11 June 2008 at 17:02

I dont think its easily possible to create the gallery menu items in a submenu, but a dropdown to choose a (toplevel) menu (Navigation [= default] or any custom menu) should be trivial to implement. Do you think thats sufficient?

Comment #2

profix898 CreditAttribution: profix898 commented 11 June 2008 at 19:29

Title:	Dynamic Menu items	» Configurable target menu for dynamic link items
Status:	Active	» Fixed

Feature added to DRUPAL-6--1 branch.
The 'Gallery menu settings' section now includes a 'Rebuild menu' button that rebuilds the gallery link items discarding all customizations. You will need to use that button, otherwise your link items will stay at their customized location.

Comment #3

profix898 CreditAttribution: profix898 commented 11 June 2008 at 19:31

Firstly, the June 10th build really works well - I have not issues with it at all!

Feels good to read this ;) Thx.

Comment #4

ToddThomson CreditAttribution: ToddThomson commented 12 June 2008 at 16:05

You're welcome!

I'll download and test your change. Feedback in a bit...

To be more specific: When adding a new menu item in drupal core the administrator can choose any "Parent Item" ( from a drop-down combo box control )for the new menu item.

Cheers!

Comment #5

ToddThomson CreditAttribution: ToddThomson commented 12 June 2008 at 16:27

It would be more consistent with the overall drupal UI if you allowed for a "parent item" for the inserted menu(s) item rather that just the top level menus ( node creation, menu item editing all support a "parent item" drop down ).

I would also suggest that the "user name" should not be used for referencing the user album. A consistent use of "Your Album" would work best. The "user name" is already used to reference the user profile.

Please note that the administrator could make all the changes above by editing the menu items after configuring the Gallery module. However from a user experience perspective it would be much better if the Gallery module provided the functionality.

Cheers!

Comment #6

ToddThomson CreditAttribution: ToddThomson commented 12 June 2008 at 17:53

Status:

Fixed

» Active

OK, I've played about with your change for a bit now...

I now understand that "user id" IS the name of the gallery album of which you have no control over ( in my test env. it is "admin" ). This is OK as production sites would have something similar to Ex: "User Albums->Admin".

I would like to make the request for an additional menu item: "Your Album". This link would be obviously per user based. From the top navigation bar ( primary menu ), it would be similar to: "Gallery->YourAlbum" ( where -> indicates a submenu listing ).

A "Album:UserID" link exists on the user profile page ( "My Account" menu item ) that shows a user specific link to the user's album.

Thanks in advance!

Comment #7

profix898 CreditAttribution: profix898 commented 13 June 2008 at 23:52

... if you allowed for a "parent item" for the inserted menu(s) item rather that just the top level menus ...

Done.

I would like to make the request for an additional menu item: "Your Album". ... it would be similar to: "Gallery->YourAlbum"

Link to useralbum feature will follow shortly. All menu items can be customized in Drupal 6, so it should be ok to have a simple checkbox for enabling the link (in the navigation menu by default). The admin can easily move the item anywhere else if desired, e.g. to the primary links, etc.

Comment #8

profix898 CreditAttribution: profix898 commented 14 June 2008 at 18:52

Status:

Active

» Needs review

File	Size
gallery_menu_useralbum.patch	1.54 KB

Do you know how to apply patches? Attached is a simple patch that adds a "UserAlbum" link to the navigation menu. For me this option feels a bit "clumsy", but maybe I simply dont see its value!? Could you please try and provide some feedback before I commit this to cvs. Thanks in advance.

Comment #9

profix898 CreditAttribution: profix898 commented 14 June 2008 at 19:51

Status:

Needs review

» Fixed

Ok, I have committed an improved version of the above patch to the DRUPAL-6--1 branch. I'd still like to get some feedback on this. Thanks.

Comment #10

ToddThomson CreditAttribution: ToddThomson commented 17 June 2008 at 16:39

Sorry about the delay getting back to you!

Firstly, the "Your Album" menu item is to allow the user to go directly to his gallery2 album. Basically to save a number of steps in the navigation process. I believe this is as relevent to the user as the list of albums that your module normally creates.

With that said, I would remove the checkbox from your UI for adding the "Your Album", and always add it along with the other menu items that are normally created. Have it created in the menu tree as per your existing UI. This is a simpler approach.

The admin can always decide to disable any of the menu items if not required.

Cheers, Todd

Comment #11

ToddThomson CreditAttribution: ToddThomson commented 18 June 2008 at 00:36

Status:

Fixed

» Active

Comment #12

profix898 CreditAttribution: profix898 commented 18 June 2008 at 20:14

Code updated to always add the "Your album" link by default. Two questions:
1. Should we make this item disabled by default (MENU_SUGGESTED_ITEM)?
2. Do we want to highlight the "Your Album" link or the actual album in the menu tree when the user navigates to his/her useralbum?

Comment #13

ToddThomson CreditAttribution: ToddThomson commented 19 June 2008 at 00:06

1) I like the disabled by default for the general case.
2) I think it is a good idea to highlight in the general case. Since I use a drop-down primary menu for navigation, once the user has selected "Your Album", the sub-menu would be hidden and thus the user would never see the highlighted menu item.

There is one last thing: I believe that it is standard practice to use "My" instead of "Your" when software references user resources. It would be better to use "My Album" and have Gallery2 change their references to use "My". Is it better to be consistent with Gallery2 and use "Your" or use standard practices?!? ( Drupal consistently uses "My" Ex: My Account )

Cheers, Todd