The Chosen library is currently being attached to every page (via hook_page_attachments()), even though most pages don't even have select elements on them. This causes unnecessary downloads for clients, which contributes to a site feeling slow for end users.
Drupal 8 does a good job of correctly bubbling attachments, so worst case you can just attach to each select element. (If not for the "whatever jQuery selector you want" feature, you could even narrow that down further so that you were only attaching to the elements that were actually using Chosen.)
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2693649-04.patch | 3.73 KB | jhedstrom |
Comments
Comment #2
jhedstromThis patch depends on #2696483: Remove redundant 'chosen_' prefix to all settings, so won't apply automatically or won't pass tests until that is committed.
Because of the option to use chosen globally (which is typically how I've used this module in the past), the library must be added for every select element. Because of the ability to attach libraries and settings to an element in D8 though, we can as suggested above, remove the global
hook_page_attachments(), and only attach the library on pages that have a select element.Comment #4
jhedstromNew patch since the previous one had missed the change to
chosen_disabled_themes.Comment #6
nagy.balint commentedComment #7
nagy.balint commentedCant we use some static cache, and if this code already ran once we don't need to run it again?
Because it will just add the same attachment and the same drupalSettings anyways.
Otherwise the patch seems to be fine.
Comment #8
jhedstromWe could, but the core
AttachedAssetsservice ensures a library isn't added more than once.Comment #9
jhedstromAnd actually, now that I'm thinking about it more, using a static could be dangerous here since render arrays may be cached, and if we don't attach the library to each instance that needs it, there could be a situation where the library doesn't properly get loaded.
Comment #10
ademarco commentedPatch #4 worked very well for me, thanks! Marking as RTBC.
Comment #12
nagy.balint commentedThanks!