When I installed Modules wight module try to update my custom module weight. I found admin menu lost favicon in left top corner, and browser can't load admin_menu_toolbar.css. So admin menu looks like not same before.

I checked system table about every module weight, found Modules weight change admin_menu_toolbar weight to -100. But admin menu module weight still is 100.

So when I changed admin_menu_toolbar weight to 100, then admin menu appearance is ok.

Why modules weight should change default module weights?

CommentFileSizeAuthor
屏幕快照 2016-03-24 下午4.31.21.png65.48 KBthlo7777

Comments

thlo7777 created an issue. See original summary.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented

Probably some issue in the code below,

/**
 * Prepares the delta for the weight field on the administration form.
 * If a module has a weight higher then 100 (or lower than 100), it will use that
 * value as delta and the '#weight' field will turn into a textfield most likely
 *
 * @param $weight
 * @return int
 */
function modules_weight_prepare_delta($weight) {
  $delta = 100;
  if ((int) $weight > $delta) {
    return (int) $weight;
  }
  if ((int) $weight < -100) {
    return (int) $weight * -1;
  }

  return $delta;
}
thlo7777’s picture

thlo7777 commented

I agree with you. From my perspective is to keep every module original weight possibly.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Active » Closed (outdated)

Thanks for reporting, It seems to be fixed in #2911901: Use the system_rebuild_module_data() function to show the modules list I'm closing this as outdated. Use for the moment the last dev version. I think that the new version will be out in the next 15 days.