This module allows administrator to add help text to node title field.

Comments

makbul_khan8 created an issue. See original summary.

jadhavdevendra’s picture

jadhavdevendra commented

I have not started working on D8 version. But you can expect the D8 release by 1st April 2016.

makbul_khan8’s picture

makbul_khan8 commented

Hi Devendra,

Do we have anything to share? I am ready to help you on this module.
Can you please create 8.x branch for this module, so that we can atleast start porting module in small sections.

Thanks

jadhavdevendra’s picture

jadhavdevendra commented

I already have created 8.x branch. I have provided you repository access. You can push your code to 8.x branch. Please let me know once you are done so that I can create new release.

Appreciate your contribution.

makbul_khan8’s picture

makbul_khan8 commented
Assigned: makbul_khan8 » Unassigned

Hi Devendra,

Can you please 8.x tag for this module please, I have my code ready and need this tag to create 8.x issue for porting to D8.
Thanks in advance!!

jadhavdevendra’s picture

jadhavdevendra commented

Hi Makbul,

I already have started working on D8 version. You can see there is 8.x-1.x branch present in the GIT. The work is in progress. You can take a look at the code and merge your code into that branch. You do have access to commit to the branch. Please let me know once you are done so that I can test and create 8 release.

Instructions are here https://www.drupal.org/project/node_title_help_text/git-instructions

Thanks.

makbul_khan8’s picture

makbul_khan8 commented

Hi Devendra,
Yes I can see branch but we can't create issue with 8.x tag as it doesn't exist.
So if you click on this url https://www.drupal.org/node/add/project-issue/node_title_help_text and select Version filter, you will only see 7.x-1.x-dev, 6.x-1.x-dev, 7.x-1.0 & 6.x-1.0 only NO 8.x-1.0
You can also check this URL for Tag information http://cgit.drupalcode.org/node_title_help_text

And if we see the Instructions are here https://www.drupal.org/project/node_title_help_text/git-instructions
It has [issue number] section on commit message.

Committing all changes locally
After making changes, add and commit them. Do not begin commit messages with the # symbol. See Commit messages for details.

git add -A
git commit -m "Issue #[issue number] by [comma-separated usernames]: [Short summary of the change]."

Please let me know if this make sense, you can also add me as maintainer of this module and I will do above things.

Also I have working code for this module in D8, so you can give more time to other issues or project.

Thanks

jadhavdevendra’s picture

jadhavdevendra commented

I already have added you as a maintainer for this module with GIT access. I prefer to keep the rights to create release and maintain project page with me. For the tagging it will start to show up once we create the first release for D8. So issue of creating D8 version for this module can be considered as feature request and can be tagged to 7.x dev release.

makbul_khan8’s picture

makbul_khan8 commented
Assigned: Unassigned » makbul_khan8

  • f23ef8a committed on 8.x-1.x 
    Issue #2691925 by makbul_khan8, jadhavdevendra: Drupal 8 version for...
makbul_khan8’s picture

makbul_khan8 commented
Assigned: makbul_khan8 » Unassigned
Status: Active » Needs review

Hi Devendra,

Thanks for adding me as maintainer, I have committed D8 version for node_title_help_text.
Can you please test the functionality in D8 and let me know if we have any issue.

If all goes well, we can release it in D8.

Thanks

makbul_khan8’s picture

makbul_khan8 commented

Hi Devendra,

Have you got chance to review code for D8 release?
Please let me know if anything pending.

Thanks

jadhavdevendra’s picture

jadhavdevendra commented

Hi Makbul,

Great work on D8 module. The code works perfectly as expected.
I just have one feedback, to store the help text currently \Drupal::state() is used. As per Drupal documentation 

Use this to store machine-generated data, local to a specific environment that does not need deploying and does not need human editing; for example, the last time cron was run. Data which needs to be edited by humans and needs to be the same across development, production, etc. environments (for example, the system maintenance message) should use \Drupal::config() instead.

I think we should use \Drupal::config() here.

jadhavdevendra’s picture

jadhavdevendra commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Needs work
makbul_khan8’s picture

makbul_khan8 commented
Assigned: Unassigned » makbul_khan8

Ok, I will fix this issue ASAP.

makbul_khan8’s picture

makbul_khan8 commented

Hi Devendra,

As per my understanding use of \Drupal::state() is right and the answer is mentioned on APIitself
Use this to store machine-generated data,
We are also using dynamic content type name to create our variable and storing value for node title help text.

Let me know if this make sense.
Thanks

jadhavdevendra’s picture

jadhavdevendra commented

We are generating variable name based on content type and storing help text which is user generated data into those variables.

https://antistatique.net/en/we/blog/2016/06/14/drupal-8-differences-betw...
State information differs from configuration in the following ways:

  1. It is specific to an individual environment.
  2. You will never deploy to deploy it between environments. !! Important
  3. You can reset a system, losing all state. Its configuration remains.
  4. + If we use config these items can be exported using features module.

https://www.drupal.org/docs/8/api/state-api

  1. It is specific to an individual environment.
  2. You will never want to deploy it between environments.
  3. You can reset a system, losing all state. Its configuration remains.
  4. So, use State API to store transient information, that is okay to lose after a reset. Think: CSRF tokens, tracking when something non-critical last happened
rolodmonkey’s picture

rolodmonkey commented

I believe that the node title help text should be exportable as configuration.

Should we create a separate ticket to make the text exportable as configuration, to keep this ticket from being cluttered?

jadhavdevendra’s picture

jadhavdevendra commented
Status: Needs work » Fixed

Created another ticket https://www.drupal.org/node/2895885

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.