README.txt is missing

CommentFileSizeAuthor
#2 2691185-2.patch1.63 KBxaiwant

Comments

xaiwant created an issue. See original summary.

xaiwant’s picture

xaiwant commented
Assigned: xaiwant » Unassigned
Status: Needs work » Needs review
Issue tags: +Novice
StatusFileSize
new 2691185-2.patch1.63 KB

Added README.txt as per drupal guidance. created patch

please review.

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Status: Needs review » Needs work

I've reviewed the patch and it is based on the README Template, which is great. Documentation for modules is a big win, so thanks for raising the issue and creating the patch.

Some of the lines are longer than 80 characters, and should be wrapped as per the documentation guidelines.

The wording and grammar in the Introduction and Requirements sections needs improving.

xaiwant’s picture

xaiwant commented
Assigned: Unassigned » xaiwant

@nicrodgers thanks for giving your precious time for reviewing the patch.
i will correct the lines which are longer than 80 characters, with improving wording and grammar in the Introduction.

xaiwant’s picture

xaiwant commented
Assigned: xaiwant » Unassigned
xaiwant’s picture

xaiwant commented
StatusFileSize
new 2691185-6.patch1.31 KB

Implemented hook_help() as per documentation guidance.
created patch

xaiwant’s picture

xaiwant commented
Assigned: Unassigned » xaiwant
xaiwant’s picture

xaiwant commented
Status: Needs work » Needs review
StatusFileSize
new 2691185-8.patch1.68 KB

applied patch with updated README.txt

xaiwant’s picture

xaiwant commented
Assigned: xaiwant » Unassigned
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: Unassigned » heykarthikwithu
Status: Needs review » Reviewed & tested by the community

looks fine.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed..

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: xaiwant » Unassigned
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.